Feature: GalaxyEspionage - #50
Draft
flashover wants to merge 2 commits into
Draft
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #50 +/- ##
===========================================
- Coverage 43.81% 42.77% -1.05%
===========================================
Files 108 108
Lines 8923 9140 +217
===========================================
Hits 3910 3910
- Misses 4907 5124 +217
Partials 106 106
Continue to review full report at Codecov.
|
…). The GalaxyEspionage2() is a simpler version of the original GalaxyEspionage(). GalaxyEspionageWithFallbackToSendFleet() calls GalaxyEspionage2() but if that fails it will fall back to SendFleet()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is code to send espionage missions directly from galaxy. Seems to work better in Ogamev7, it makes less galaxyurl() calls. Code could be simpler if it would return immediately if the JSON struct would have
success = false. But it needs some kind of statemachine to forcefully refresh and get new token (=galaxyurl()).Let me know your thoughts!