Fix PHP 8.4 deprecated warning by making $resource parameter explicitly nullable #1871
+20
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes a PHP 8.4 compatibility issue occurring in the Run/Grid/Collection and related grid collection classes.
PHP 8.3+ deprecates implicitly nullable parameters when a parameter defaults to null but is not explicitly typed as nullable.
Magento 2.4.8+ and PHP 8.4+ trigger the following deprecated warning:
Deprecated Functionality: Implicitly marking parameter $resource as nullable is deprecated,
the explicit nullable type must be used instead
This happens because the constructor declares:
\Magento\Framework\Model\ResourceModel\Db\AbstractDb $resource = nullInstead of:
?\Magento\Framework\Model\ResourceModel\Db\AbstractDb $resource = nullWhat this PR does
Why this change is needed
Magento 2.4.x now requires PHP 8.3+ compatibility.
Without this fix, Algolia’s Magento module triggers repeated deprecated notices, particularly on CLI usage and in admin grids.
This PR ensures full compatibility with PHP’s updated typing rules.
Testing
Backward compatibility