Skip to content

Use original file name and extension for image URLs #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use original file name and extension for image URLs #158

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddcc2d0
Revert "Restores proper image handling for iOS. Reverts changes in ht…
chaitanyadeorukhkar Jun 12, 2019
95817f3
Use original file name with extension
chaitanyadeorukhkar Jun 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions ios/ReactNativeShareExtension.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,33 @@ - (void)extractDataFromContext:(NSExtensionContext *)context withCallback:(void(
}];
} else if (imageProvider) {
[imageProvider loadItemForTypeIdentifier:IMAGE_IDENTIFIER options:nil completionHandler:^(id<NSSecureCoding> item, NSError *error) {
NSURL *url = (NSURL *)item;


/**
* Save the image to NSTemporaryDirectory(), which cleans itself tri-daily.
* This is necessary as the iOS 11 screenshot editor gives us a UIImage, while
* sharing from Photos and similar apps gives us a URL
* Therefore the solution is to save a UIImage, either way, and return the local path to that temp UIImage
* This path will be sent to React Native and can be processed and accessed RN side.
**/

UIImage *sharedImage;
NSString *filePath = nil;
NSString *fullPath = nil;

if ([(NSObject *)item isKindOfClass:[UIImage class]]){
sharedImage = (UIImage *)item;
fullPath = [NSTemporaryDirectory() stringByAppendingPathComponent:@"Image.png"];
}else if ([(NSObject *)item isKindOfClass:[NSURL class]]){
NSURL* url = (NSURL *)item;
fullPath = [NSTemporaryDirectory() stringByAppendingPathComponent:url.lastPathComponent];
NSData *data = [NSData dataWithContentsOfURL:url];
sharedImage = [UIImage imageWithData:data];
}

[UIImagePNGRepresentation(sharedImage) writeToFile:fullPath atomically:YES];

if(callback) {
callback([url absoluteString], [[[url absoluteString] pathExtension] lowercaseString], nil);
callback(fullPath, [fullPath pathExtension], nil);
}
}];
} else if (textProvider) {
Expand Down