Change dynamic imports to static imports to fix bundling with ESBuild #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alixaxel This is a very small change, can we please merge this? Pretty please 🙏? I don't want to fork 😅 |
|
+1 to this |
|
This fix is required for Webpack 5 with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESBuild does not allow dynamic imports, thus throwing errors when reaching the
requireimport changed by this PR. At runtime, therequirelooks for the file in whichever directory we are in (__dirname).The changes proposed were tested and work both for Webpack and ESBuild.