Skip to content

Do not add ('not trusted') to untrusted client name #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Do not add ('not trusted') to untrusted client name #232

wants to merge 2 commits into from

Conversation

andrzejwaw
Copy link
Contributor

No description provided.

@slonka slonka temporarily deployed to envoy-control-pr-232 December 15, 2020 12:26 Inactive
@slonka
Copy link
Contributor

slonka commented Dec 15, 2020

Do not merge until our environment is ready.

lukidzi
lukidzi previously approved these changes Dec 17, 2020
View reviewed changes
@slonka
Copy link
Contributor

slonka commented Mar 2, 2021 •
edited
Loading

@lukidzi do you remember the requirement here? do we need wrapper in a certain version?

EDITED:
yes, we need newest wrapper, then this change, then we can clean up wrapper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@lukidzi lukidzi lukidzi left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrzejwaw @slonka @lukidzi