Fix CFrameActionMngr (RequestFrame) not being cleared #1076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be ideal to integrate. Nice work |
lozatto
approved these changes
Jan 16, 2024
MisterCalvin
added a commit
to MisterCalvin/amxmodx
that referenced
this pull request
Nov 13, 2025
The fix looks like a workaround because there is no clear method in amtl/am-deque.h and i don't know if i can or how to call it directly if i were better at C stuff i could make a pr to add a clear method on am-deque first Fixes alliedmodders#1039, also don't forget to apply it to 1.9-dev too. Applied from upstream repo: alliedmodders#1076
Contributor
Contributor
Author
|
sorry, haven't been able to test it on 1.10, as uses newer amtl and .clear() seems to be callable in there |
Contributor
Author
|
can we get this merged for 1.9-dev too? or it needs another pr? |
psychonic
pushed a commit
that referenced
this pull request
Nov 14, 2025
Co-authored-by: Th3-822 <[email protected]> (cherry picked from commit 48c9828)
Member
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix looks like a workaround because there is no clear method in amtl/am-deque.h and i don't know if i can or how to call it directly
if i were better at C stuff i could make a pr to add a clear method on am-deque first
Fixes #1039, also don't forget to apply it to 1.9-dev too