Skip to content

Fix MacOS SDL3 build #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

Conversation

jean-dao
Copy link

@jean-dao jean-dao commented Apr 5, 2025

This IMG_ImageIO.m file is required to build on MacOS.

@jayschwa
Copy link
Collaborator

jayschwa commented Apr 6, 2025

Thanks. I'll probably merge, but a couple questions first:

  • Is the package currently broken on MacOS? Or do you just want to use the native framework?
  • With this change, have you verified that it's actually using the correct code path? To use the native framework, I would have guessed that some new macro definition is required to replace / in addition to lib.root_module.addCMacro("USE_STBIMAGE", "");

@jean-dao
Copy link
Author

jean-dao commented Apr 7, 2025

* Is the package currently broken on MacOS? Or do you just want to use the native framework?

The package builds fine on its own, but IMG_Load is not included so it's not usable.

* With this change, have you verified that it's actually using the correct code path? To use the native framework, I would have guessed that some new macro definition is required to replace / in addition to `lib.root_module.addCMacro("USE_STBIMAGE", "");`

Actually, it is working because the native frameworks are linked by the SDL lib. Should it be explicitly linked here as well?

@jayschwa
Copy link
Collaborator

jayschwa commented Apr 8, 2025

Actually, it is working because the native frameworks are linked by the SDL lib. Should it be explicitly linked here as well?

Yeah, any libraries or frameworks that ImageIO.m requires should probably be explicitly linked.

@jean-dao
Copy link
Author

jean-dao commented Apr 8, 2025

Frameworks used explicitly linked on both branches.

@jayschwa jayschwa merged commit 45a1701 into allyourcodebase:main Apr 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants