Skip to content

Conversation

@agagniere
Copy link
Member

A replacement of #4 that keeps compatibility with 0.14

@agagniere agagniere self-assigned this Jan 5, 2026
Copy link
Contributor

@torque torque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, for whatever my opinion is worth

@agagniere
Copy link
Member Author

@torque So this change has a consequence I should have maybe highlighted:

previously all 3 libs would export all headers.

now, libtls only exports tls.h, and libssl exports the openssl header folder, while libcrypto doesn't export headers at all.

Because I've only ever used libssl (e.g. in libpq) it works for my use case.

But there may have been reasons to export all headers from all libs ? in particular libcrypto

@torque
Copy link
Contributor

torque commented Jan 7, 2026

I expect most projects that use libressl are using the openssl bindings rather than the libtls API, so checking whether or not the header situation actually works for those may be less trivial to do. zig build -Dbuild-apps still appears to work on this branch, at least, though I'd need to check that that's not cheating with the headers. I'll poke it in a little bit more detail tomorrow.

@torque
Copy link
Contributor

torque commented Jan 8, 2026

I fiddled around with a couple of other things and they appear to build ok. I think having libtls not export the openssl includes makes more sense than what was being done before. Merge at will.

@agagniere agagniere merged commit 43f34e8 into master Jan 8, 2026
10 checks passed
@agagniere agagniere deleted the simplify-installheader branch January 8, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants