-
-
Notifications
You must be signed in to change notification settings - Fork 26
Roundels! #1460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Loqor
wants to merge
64
commits into
main
Choose a base branch
from
feat/roundels
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Roundels! #1460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… have schoolwork to do
fix: dynamicy
fix: fabricator no more on ground
fix: emission is now constant and not dumb
… that includes the emissive boolean that can be set via the roundel fabricator (currently is simply set to true for testing)
Skill issue, clearly |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
# Conflicts: # src/main/java/dev/amble/ait/AITMod.java # src/main/java/dev/amble/ait/client/AITModClient.java
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A: Console
Area: Tardis console.
A: Datagen
Area: Datagen implementation & API.
A: Tardis Components
Area: Tardis components & manager.
C: Textures
Changes: Might require knowledge of spriting or visual design.
S: Merge Conflict
Status: Needs to resolve merge conflicts before it can be accepted.
S: Needs Review
Status: Requires additional reviews before being fully accepted.
size/M
Denotes a PR that changes 100-999 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Added Roundels, Roundel Fabricator, and a new datapack system for patterns.
Why / Balance
I'll explain later
Technical details
Media
Requirements
Breaking changes
Changelog