Skip to content

Immersive Portals Compatability #1792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

Immersive Portals Compatability #1792

wants to merge 38 commits into from

Conversation

duzos
Copy link
Member

@duzos duzos commented Aug 6, 2025 •
edited by drtheodor
Loading

About the PR

This PR adds back IP compat from 1.0.5. BOTI is disabled for geometric, capsules and dalek mod exteriors for now.

Media

Requirements

Changelog

🆑

  • fix: the door properly copies lighting from the exterior now
  • add: BOTI is real with immersive portals now WOOO (with massive financial support from <@1264511380619268148>/JayJay). To turn it on install IP and enable the "experimental IP" options in both server and client config of AIT and then restart your game.
  • fix: it shouldnt be possible to get stuck in the time vortex now

@github-actions github-actions bot added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Aug 6, 2025
@drtheodor
Copy link
Member

bro saw IP and gave up

@duzos
Copy link
Member Author

duzos commented Aug 6, 2025

its nearly there im just tired

duzos and others added 9 commits August 6, 2025 22:08
@duzos
bro imgonna hurt someone
8cf8e2e
@drtheodor
fix: mod no longer blows up when you're playing without IP
f7bb9ad 
fix: no unnecessary networking anymore
chore: added todo comments

Signed-off-by: Theo <[email protected]>
@drtheodor
warn & disable boti on macos
6ac5862 
Signed-off-by: Theo <[email protected]>
@drtheodor
add a null check to os check
414e94b 
Signed-off-by: Theo <[email protected]>
@drtheodor
dont remap create method
5ceb62b 
Signed-off-by: Theo <[email protected]>
@drtheodor
fix: remove missing mixins
3916358 
Signed-off-by: Theo <[email protected]>
@drtheodor
ugh
77eeed6 
Signed-off-by: Theo <[email protected]>
@drtheodor
possibly fix relog issues
1ca842c 
fix: tardis world deletion

Signed-off-by: Theo <[email protected]>
@drtheodor
dont lose track of the portals
96366be 
Signed-off-by: Theo <[email protected]>
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted. label Aug 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted. label Sep 7, 2025
@drtheodor drtheodor force-pushed the main branch 2 times, most recently from 5bf894b to 427c00d Compare September 7, 2025 03:11
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted. label Sep 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added C: Textures Changes: Might require knowledge of spriting or visual design. A: Datagen Area: Datagen implementation & API. C: Audio Changes: Might require knowledge of audio. A: Admin Tooling Area: Admin tooling and moderation. labels Sep 7, 2025
@drtheodor
Merge branch 'main' into feat/boti_ip
cd070a5 
# Conflicts:
#	build.gradle
#	gradle.properties
#	src/main/java/dev/amble/ait/client/AITModClient.java
@drtheodor
add config options to disable IP compat on both client and server
227dc3c 
Signed-off-by: Theo <[email protected]>
@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted. label Oct 1, 2025
drtheodor and others added 2 commits October 5, 2025 12:34
@drtheodor
Update PortalsHandler.java
93519c4
@drtheodor
practically finish IP compat
badbb8b 
feat: visualizer screen & control to show the view around the tardis
fix: world no longer crashes on relog with IP
feat: everything respects the IP config now
fix: creative tardis item rewards the player with the advancement properly now
fix: door block now handles exterior light level correctly
fix: ip teleportation now fires world change event

Signed-off-by: DrTheodor <[email protected]>
@drtheodor
fix: disable portal passthrough interactions
bf10b1b 
Signed-off-by: DrTheodor <[email protected]>
@drtheodor
fix: dont open visualizer if not landed
55456e2 
fix: dont render tardis star if the world is not the real world
fix: put time vortex as the destination portal during flight
fix: no more scheduled tp out of the vortex

Signed-off-by: DrTheodor <[email protected]>
@drtheodor drtheodor marked this pull request as ready for review October 5, 2025 22:20
@drtheodor drtheodor requested review from a team as code owners October 5, 2025 22:20
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted. label Oct 5, 2025
@github-actions github-actions bot added the size/M Denotes a PR that changes 100-999 lines. label Oct 5, 2025
@GSMPBot GSMPBot requested a review from drtheodor October 5, 2025 22:22
@drtheodor drtheodor added T: New Feature Type: New feature or content, or extending existing content. T: Of Admin Interest Type: Affects administration work a lot, and might require admins to weigh in on. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Oct 5, 2025
@drtheodor
chore: optimize imports
079d58e 
Signed-off-by: DrTheodor <[email protected]>
@drtheodor drtheodor added the S: Needs Testing Status: Requires testing. label Oct 6, 2025
@drtheodor
fix: remove portals on tardis removal
aadb335 
Signed-off-by: DrTheodor <[email protected]>
@drtheodor
perf: slightly optimize door updates since last commit
05b757a 
Signed-off-by: DrTheodor <[email protected]>
@drtheodor
fix: no more weird world desync crash
8b99154 
Signed-off-by: DrTheodor <[email protected]>
@drtheodor
fix: properly handle tardis world loading in multiplayer with IP
3837475 
Signed-off-by: DrTheodor <[email protected]>
@drtheodor
fix: disable BOTI on dalek mod exteriors
cf4e7d4 
Signed-off-by: DrTheodor <[email protected]>
@drtheodor
fix: disable BOTI on geometric exteriors
b9edac0 
Signed-off-by: DrTheodor <[email protected]>
@drtheodor
fix: awesome emission overlay BOTI fix
f3a8d4d 
Signed-off-by: DrTheodor <[email protected]>
@drtheodor
fix: visualizer offset
b99aed9 
Signed-off-by: DrTheodor <[email protected]>
@drtheodor
fix: remove the confusing obsolete interior BOTI option from config
a34ea02 
Signed-off-by: DrTheodor <[email protected]>
@drtheodor drtheodor removed the S: Needs Testing Status: Requires testing. label Oct 6, 2025
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted. label Oct 12, 2025
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@smallmoss233
Copy link

2025-10-19_17 05 06 2025-10-19_17 12 31

There's a bug when Iris is added; looking through a door from the inside shows the outside as if it's covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drtheodor drtheodor Awaiting requested review from drtheodor

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

A: Admin Tooling Area: Admin tooling and moderation. A: Console Area: Tardis console. A: Datagen Area: Datagen implementation & API. A: Tardis Components Area: Tardis components & manager. C: Audio Changes: Might require knowledge of audio. C: Textures Changes: Might require knowledge of spriting or visual design. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted. S: Needs Review Status: Requires additional reviews before being fully accepted. size/M Denotes a PR that changes 100-999 lines. T: New Feature Type: New feature or content, or extending existing content. T: Of Admin Interest Type: Affects administration work a lot, and might require admins to weigh in on.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@duzos @drtheodor @smallmoss233 @Loqor