Skip to content

fix: tardises can now properly grow in any dimension properly even if they're locked #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: tardises can now properly grow in any dimension properly even if they're locked #1908

wants to merge 1 commit into from

Conversation

Loqor
Copy link
Member

@Loqor Loqor commented Sep 22, 2025

About the PR

Made the TARDIS auto-unlock a dimension if its grown there.

Why / Balance

To 1. fix issues when growing TARDIS' in other dimensions if locked, and 2. to balance and help players wanting to start in other dimensions.

Technical details

Simply just test for the world and if its lockable and then, unlock it. easy as.

Media

Requirements

Breaking changes

Changelog

🆑

  • fix: TARDIS' can now grow and reland in other locked dimensions!

@Loqor Loqor requested a review from a team as a code owner September 22, 2025 05:01
@Loqor Loqor self-assigned this Sep 22, 2025
@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines. S: Needs Review Status: Requires additional reviews before being fully accepted. A: Tardis Components Area: Tardis components & manager. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. labels Sep 22, 2025
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted. label Sep 22, 2025
@Loqor Loqor added T: Bugfix Type: Bugs and/or bugfixes. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it. P1: High Priority: Higher priority than other items, but isn't an emergency. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines. A: Tardis Components Area: Tardis components & manager. labels Sep 22, 2025
drtheodor
drtheodor approved these changes Sep 22, 2025
View reviewed changes
Copy link
Member

@drtheodor drtheodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested?

@github-actions github-actions bot added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. labels Sep 22, 2025
@Loqor
Copy link
Member Author

Loqor commented Sep 22, 2025

yeah should work just fine - im giving it the registry identifier and not the value identifier for the getter of the lockable dim thing, so i think it should be okay?

@Mansarde
Copy link
Member

I just tested it, and it doesn't work.

When placing a creative TARDIS in the End or the Nether, then traveling to the same dimension makes the TARDIS refuse to land.
The dimension selector also shows these dimensions as still locked.

Besides that, you can't place down a TARDIS coral on a soul sand in these two dimensions, so only creative TARDISes can be placed.

@drtheodor
Copy link
Member

guh

duzos
duzos requested changes Oct 12, 2025
View reviewed changes
Copy link
Member

@duzos duzos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix bug

@github-actions github-actions bot added the S: Awaiting Changes Status: Changes are required before another review can happen. label Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@duzos duzos duzos requested changes

@drtheodor drtheodor drtheodor approved these changes

@MaketendoDev MaketendoDev Awaiting requested review from MaketendoDev

Requested changes must be addressed to merge this pull request.

Assignees

@Loqor Loqor

Labels

P1: High Priority: Higher priority than other items, but isn't an emergency. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Awaiting Changes Status: Changes are required before another review can happen. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it. T: Bugfix Type: Bugs and/or bugfixes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Loqor @Mansarde @drtheodor @duzos