Skip to content

Hapyfromeatgift #1917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: feat/mood
Choose a base branch
from
Open

Hapyfromeatgift #1917

wants to merge 3 commits into from

Conversation

rapbattlegod32
Copy link
Member

About the PR

Why / Balance

Technical details

Media

https://media.discordapp.net/attachments/739455473476042844/1421915599042379866/temp_image_D7E59F2F-4905-4DF4-8577-2FB9770AB08E.webp?ex=68e0b458&is=68df62d8&hm=324e7487ed2c25c0b7d9758d3971487d4e068564504b0d1570871a4a25f79cde&=&format=webp&width=1188&height=1155

Requirements

Breaking changes

Changelog

@rapbattlegod32 rapbattlegod32 requested a review from a team as a code owner October 3, 2025 09:03
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. A: Tardis Components Area: Tardis components & manager. A: Admin Tooling Area: Admin tooling and moderation. A: Console Area: Tardis console. size/M Denotes a PR that changes 100-999 lines. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. labels Oct 3, 2025
@GSMPBot GSMPBot requested review from drtheodor and duzos October 3, 2025 09:03
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted. label Oct 3, 2025
@duzos duzos changed the base branch from main to feat/mood October 3, 2025 09:05
duzos
duzos approved these changes Oct 3, 2025
View reviewed changes
Copy link
Member

@duzos duzos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bro got geeked

@duzos duzos requested a review from Copilot October 3, 2025 09:06
@github-actions github-actions bot added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. labels Oct 3, 2025
Copilot
Copilot AI reviewed Oct 3, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a mechanism to give TARDIS-specific cookies as rewards that can affect a TARDIS's mood when consumed. The implementation uses a mixin to intercept food eating and NBT data to link cookies to specific TARDIS instances.

  • Adds a mixin to handle cookie consumption and TARDIS mood modification
  • Modifies the sequence registry to create special cookies with TARDIS UUID data
  • Updates the mixin configuration to include the new functionality

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/main/resources/ait.mixins.json Registers the new mixin class for cookie handling
src/main/java/dev/amble/ait/registry/impl/SequenceRegistry.java Creates special cookies with TARDIS UUID and multiplier data as rewards
src/main/java/dev/amble/ait/mixin/sexygifthapy.java Implements the mixin to detect cookie consumption and modify TARDIS mood

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

src/main/java/dev/amble/ait/mixin/sexygifthapy.java Outdated
Comment on lines 47 to 48
MoodHandler2 mood = new MoodHandler2();
mood.add(Emotion.Type.CONTENT, data.getFloat("Multiplier"));
Copy link

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new MoodHandler2 instance is created but never applied to the TARDIS. The mood changes will have no effect. You should get the existing mood handler from the TARDIS and modify it, or apply this handler to the TARDIS.

Suggested change
MoodHandler2 mood = new MoodHandler2();
mood.add(Emotion.Type.CONTENT, data.getFloat("Multiplier"));
MoodHandler2 mood = tardis.getMoodHandler();
if (mood != null) {
mood.add(Emotion.Type.CONTENT, data.getFloat("Multiplier"));
}

Copilot uses AI. Check for mistakes.

@rapbattlegod32
Copy link
Member Author

im never liding no sleep again im so fucking retarded rn

Mansarde
Mansarde requested changes Oct 3, 2025
View reviewed changes
@github-actions github-actions bot added S: Awaiting Changes Status: Changes are required before another review can happen. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. labels Oct 3, 2025
Mansarde
Mansarde requested changes Oct 3, 2025
View reviewed changes
src/main/java/dev/amble/ait/registry/impl/SequenceRegistry.java
ItemStack poppy = new ItemStack(Items.POPPY);

NbtCompound cookienbt = cookie.getOrCreateNbt();
// NbtCompound poppynbt = poppy.getOrCreateNbt();
Copy link
Member

@Mansarde Mansarde Oct 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this commented out code (this and some lines below) was probably just to limit the TARDIS to cookies during development.
Re-enable them again by un-commenting the lines related to this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah im not finished with it still need to do the poppy and it was 8am tired af i didnt wanna do it ill do it it when i get back from hanging out with some friends

Mansarde
Mansarde requested changes Oct 3, 2025
View reviewed changes
@Mansarde Mansarde removed the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Oct 3, 2025
@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. and removed size/M Denotes a PR that changes 100-999 lines. labels Oct 3, 2025
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted. S: Awaiting Changes Status: Changes are required before another review can happen. and removed S: Awaiting Changes Status: Changes are required before another review can happen. S: Needs Review Status: Requires additional reviews before being fully accepted. labels Oct 3, 2025
@rapbattlegod32
Copy link
Member Author

also this isnt ready yet still need to do the poppy, but ill do that when i get back

@Mansarde
Copy link
Member

Mansarde commented Oct 3, 2025

There was already an existing mixin for LivingEntity, which made the extra mixin redundant.
So I moved the method over there and removed the obsolete mixin.

@MaketendoDev
Copy link
Member

don't make it a specific item make a tag for item so then datapack/addon devs can do whatever they want with it

@rapbattlegod32
Copy link
Member Author

do

you do it then

@MaketendoDev
Copy link
Member

no its your pull

MaketendoDev
MaketendoDev requested changes Oct 3, 2025
View reviewed changes
Copy link
Member

@MaketendoDev MaketendoDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tags please kind sir

@MaketendoDev
Copy link
Member

and it isnt that hard to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mansarde Mansarde Mansarde requested changes

Copilot code review Copilot Copilot left review comments

@MaketendoDev MaketendoDev MaketendoDev requested changes

@drtheodor drtheodor Awaiting requested review from drtheodor

@Loqor Loqor Awaiting requested review from Loqor

@duzos duzos Awaiting requested review from duzos

Assignees

No one assigned

Labels

A: Admin Tooling Area: Admin tooling and moderation. A: Console Area: Tardis console. A: Tardis Components Area: Tardis components & manager. S: Awaiting Changes Status: Changes are required before another review can happen. size/S Denotes a PR that changes 10-99 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rapbattlegod32 @Mansarde @MaketendoDev @duzos