Skip to content

Fix fetching relative stylesheet URLs #4284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Fix fetching relative stylesheet URLs #4284

wants to merge 3 commits into from

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Feb 12, 2020 •
edited
Loading

Summary

Fixes #4599.

Also:

  • Eliminate relative paths for images and other elements in the page.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@googlebot googlebot added the cla: yes Signed the Google CLA label Feb 12, 2020
@westonruter westonruter added this to the v1.5 milestone Feb 12, 2020
@westonruter westonruter self-assigned this Feb 12, 2020
@westonruter westonruter force-pushed the fix/relative-stylesheet-urls branch 2 times, most recently from 7627128 to e6d9ad4 Compare February 18, 2020 03:45
@westonruter westonruter force-pushed the fix/relative-stylesheet-urls branch from 4a08b95 to d4d44b3 Compare February 24, 2020 23:38
@westonruter westonruter modified the milestones: v1.5, v1.6 Mar 18, 2020
@westonruter westonruter removed this from the v1.6 milestone Apr 16, 2020
@westonruter
Merge branch 'develop' of github.com:ampproject/amp-wp into fix/relat…
3f06c8e 
…ive-stylesheet-urls

* 'develop' of github.com:ampproject/amp-wp: (962 commits)
  Fix hasChanges/hasSaved logic in unsaved changes warning
  Update assets/src/setup/components/unsaved-changes-warning/index.js
  Use *.snap instead of __snapshots__ in .gitattributes
  Add beforeunload listener only after changes
  Set version option to readonly
  JS doc param fix
  Remove unnecessary checks
  Set linguist-generated for Jest snapshots
  Setup wizard: Update screen titles
  Fix issue with setup wizard mobile width
  Add unsaved changes warning message
  Skip broken test that needs fix upstream
  Only use 'all and...' in conjunction with 'not'
  Keep selectors unsorted
  Fix CS in markup comparison helper
  Adapt ServerSideRendering transformer to make use of CssRule(s)
  Add CssRules collection class and tests
  Add CssRule class and tests
  Move attribute-order-agnostic comparison to assertSimilarMarkup()
  Normalize start tag attributes by sorting and squashing whitespace
  ...
@schlessera schlessera added the WS:Core Work stream for Plugin core label Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@westonruter westonruter

Labels

cla: yes Signed the Google CLA WS:Core Work stream for Plugin core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Relative URLs should be made absolute to promote embeddability

3 participants

@westonruter @schlessera @googlebot