Skip to content

Update allowed tags/attributes from spec in amphtml 2003031842100 #4390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 18, 2020
Merged

Update allowed tags/attributes from spec in amphtml 2003031842100 #4390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
18ff05d
Update allowed tags/attributes from spec in amphtml 2003031842100
westonruter Mar 15, 2020
897b5d3
Ensure unique GetMandatoryOf parsed from spec
westonruter Mar 15, 2020
3882475
Remove test for obsolete component amp-user-location
westonruter Mar 16, 2020
f02c712
Add test for amp-inline-gallery
westonruter Mar 16, 2020
0c134ee
Add tests for amp-nested-menu, amp-mega-menu, amp-autocomplete, dock …
westonruter Mar 16, 2020
398f3f1
Add tests for amp-script, amp-next-page, amp-date-picker, and amp-red…
westonruter Mar 16, 2020
bc1e70b
Add test for amp-story-page[next-page-no-ad], input[type=button], and…
westonruter Mar 17, 2020
72b6554
Add test for form validation and amp-next-page
westonruter Mar 17, 2020
da10be2
Add test for amp-subscriptions and note what is lacking
westonruter Mar 17, 2020
196a084
Add tests for non-reference point amp-mega-menu markup
westonruter Mar 18, 2020
7550879
Add (failing) tests for amp-mega-menu reference points
westonruter Mar 18, 2020
771d59f
Revert "Add (failing) tests for amp-mega-menu reference points"
westonruter Mar 18, 2020
68f283b
Add test for amp-nested-menu with amp-list
westonruter Mar 18, 2020
4283c88
Add test for amp-inline-gallery with thumbnails
westonruter Mar 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions bin/amphtml-update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -787,10 +787,10 @@ def GetMandatoryOf( attr, constraint ):
Returns:
A list of attributes that have that constraint name.
"""
attributes = []
attributes = set()
for attr_spec in attr:
if attr_spec.HasField(constraint):
attributes.append(
attributes.add(
# Convert something like [src] to data-amp-bind-src.
re.sub(
"^\[(\S+)\]$",
Expand All @@ -799,8 +799,7 @@ def GetMandatoryOf( attr, constraint ):
)
)

attributes.sort()
return attributes
return sorted(attributes)

def Phpize(data, indent=0):
"""Helper function to convert JSON-serializable data into PHP literals.
Expand Down
Loading