Add a new workflow to ensure that new contributions are correctly typed #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While we appreciate the idea of automated checks on pull requests, we are hesitant to rely on a relatively unknown GitHub Action. We will work on reducing the current issues flagged by static code analysis tools, and then introduce very plain and simple workflows to check pull requests. |
|
Ok :) |
|
I chose reviewdog, because it only critiques lines that were actually touched by a pull request. (Not primarily because of the inline annotations.) I didn't want to burden contributors with errors they didn't introduce themselves. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is a spin-off of #127.)