-
Notifications
You must be signed in to change notification settings - Fork 220
Add Gemini Nano support for prompt validation with fallback mechanism #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Gemini Nano support for prompt validation with fallback mechanism #171
Conversation
Summary of ChangesHello @takahirom, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates Gemini Nano into the prompt validation workflow, mirroring the existing image validation strategy. Previously, prompt validation exclusively used Firebase AI, while image validation leveraged Gemini Nano with a Firebase AI fallback. This change introduces Gemini Nano as the primary validation method for prompts, with Firebase AI serving as a robust backup, ensuring consistency across validation processes and potentially enhancing performance or capabilities. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a great addition, bringing consistency to the app by adding Gemini Nano support for prompt validation with a fallback mechanism, similar to the existing image validation. The changes are well-structured, including updates to data sources, remote config, and tests.
I've left a couple of suggestions. One is a high-severity recommendation to improve the fallback logic to be more robust, ensuring it triggers not just when Nano is unavailable, but also when Nano's validation fails. This aligns better with the likely intent and improves reliability. The other is a minor suggestion for code conciseness.
Overall, excellent work on improving the app's on-device capabilities!


Thanks for this awesome reference app! I'm going to talk about this app in DevFest Tokyo.
While exploring the codebase, I noticed that Androidify uses Gemini Nano for image validation (
validateImageHasEnoughInformation) with a fallback to Firebase AI, but prompt validation(
validatePromptHasEnoughInformation) only uses Firebase AI directly.I'm curious about the Gemini Nano strategy here. Is there a specific reason why prompt validation doesn't leverage Gemini Nano? If not, this PR adds Gemini Nano support for prompt validation to maintain
consistency with the existing image validation pattern.
Changes
promptTextVerifyNano()to RemoteConfigDataSource with validation promptvalidatePromptHasEnoughInformation()to GeminiNanoGenerationDataSourceImageGenerationRepositoryto try Gemini Nano first, then fallback to Firebase AILet me know if there's a specific reason this pattern wasn't used for prompt validation!