Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Conversation

cartland
Copy link

@cartland cartland commented May 5, 2025

This PR standardizes GitHub Actions triggers in workflow files within .github/workflows/.

The goal is to ensure workflows run consistently on push, pull_request, and workflow_dispatch events where appropriate.

This is part of a batch of pull requests across repositories owned by the android organization on GitHub.

Project Owner: Please review the changes carefully to ensure they are correct and appropriate for this project before approving and merging.

  • If you do not think this change is appropriate (e.g., a workflow should NOT run on one of these triggers), please leave a comment explaining why.
  • If you think the goal is appropriate but notice a mistake in the implementation, please leave a comment detailing the mistake.

Copy link

Note

The files in this pull request are not supported by Gemini Code Assist.

@cartland
Copy link
Author

cartland commented May 5, 2025

CI is not working on this repository, likely due to this issue:

The ubuntu-18.04 environment is deprecated, consider switching to ubuntu-20.04(ubuntu-latest), or ubuntu-22.04 instead. For more details see actions/runner-images#6002

I will try to update the environment to ubuntu-20.04.

cartland added 2 commits May 5, 2025 14:12
Fixes this error: The ubuntu-18.04 environment is deprecated, consider switching to ubuntu-20.04(ubuntu-latest),
or ubuntu-22.04 instead. For more details see actions/runner-images#6002
Responding to error: "This is a scheduled Ubuntu 20.04 retirement.
Ubuntu 20.04 LTS runner will be removed on 2025-04-15.
For more details, see actions/runner-images#11101""
@cartland
Copy link
Author

cartland commented May 5, 2025

ubuntu-20.04 also has a deprecation plan. Switching to ubuntu-latest so that we need to do fewer updates on our end. Since we're required to update so often, CI will probably be more stable with latest than a specific version number.

cartland added 11 commits May 5, 2025 15:11
The builds are failing:
* Error: Missing download info for actions/upload-artifact@v1
The builds are failing and need the updated versions:
* actions/checkout@v4
* actions/setup-java@v2
This commit refactors the Android workflow to build each
sample individually.

- Removes the gradlew_recursive.sh script.
- Adds individual jobs for each sample.
- Each job checks out the code, sets up JDK 11, and builds
  the sample.
This commit adds a new job to the Android workflow that
uploads the build artifacts for each sample.

- Uses actions/upload-artifact@v4 to upload the build
  artifacts.
- Sets the name of the artifact to the sample name plus
  "-build".
- Sets the path to the app/build/outputs/ directory for
  each sample.
This commit updates the buildToolsVersion and
targetSdkVersion in the build.gradle files of the
FileManager, FileProvider, and SafDemos samples.

- FileManager:
  - Updated buildToolsVersion from "29.0.2" to "30.0.3"
- FileProvider:
  - Updated buildToolsVersion from "29.0.3" to "30.0.3"
  - Updated targetSdkVersion from 29 to 30
- SafDemos:
  - Updated targetSdkVersion from 29 to 31
This commit updates the Gradle version of the FileManager sample.

- Updates the Gradle version to 7.5.
- Updates the AGP version to 7.4.2.
- Updates the Kotlin version to 1.6.21.
- Sets the namespace in the module build file.
This commit updates the Gradle version of the FileProvider
sample.

- Updates the Gradle version to 7.5.
- Updates the AGP version to 7.4.2.
- Updates the Kotlin version to 1.6.21.
- Sets the namespace in the module build file.
This commit updates the targetSdkVersion in the
build.gradle file of the FileProvider sample.

- Updated targetSdkVersion from 30 to 31
- Added exported=true to MainActivity
This commit updates the Gradle version of the SafDemos sample.

- Updates the Gradle version to 7.5.
- Updates the AGP version to 7.4.2.
- Updates the Kotlin version to 1.6.21.
- Sets the namespace in the module build file.
- Added exported=true to MainActivity
@cartland
Copy link
Author

@yrezgui I fixed the builds.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant