Skip to content

added support to spawn threads from electron asar bundles #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added support to spawn threads from electron asar bundles #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/master/implementation.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,13 @@ function initWorkerThreadsWorker(): ImplementationExport {
} else if (resolvedScriptPath.match(/\.tsx?$/i) && detectTsNode()) {
super(createTsNodeModule(resolvedScriptPath), { ...options, eval: true })
} else if (resolvedScriptPath.match(/\.asar[\/\\]/)) {
// See <https://github.com/andywer/threads-plugin/issues/17>
super(resolvedScriptPath.replace(/\.asar([\/\\])/, ".asar.unpacked$1"), options)
const electronPath =
options?.electronAsarUnpacked === false
? resolvedScriptPath
// See <https://github.com/andywer/threads-plugin/issues/17>
: resolvedScriptPath.replace(/\.asar([\/\\])/, ".asar.unpacked$1")

super(electronPath, options)
} else {
super(resolvedScriptPath, options)
}
Expand Down
4 changes: 4 additions & 0 deletions src/types/master.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,10 @@ export interface ThreadsWorkerOptions extends WorkerOptions {
/** Data passed on to node.js worker_threads. */
workerData?: any

/** If Electron workers should use the asar.unpacked path. Default to true.
* See <https://github.com/andywer/threads-plugin/issues/17> */
electronAsarUnpacked?: boolean

/** Whether to apply CORS protection workaround. Defaults to true. */
CORSWorkaround?: boolean
}
Expand Down