Fix SSE url check never reaching setupSSEConnection. #949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with the SSE-connection logic.
A check exists
if (url !== this.endpoint) { return next() }
wherethis.endpoint
default starts with a/
, example/@angular-architects/native-federation:build-notifications
and the incomingurl
variable gets stripped to being without a leading/
. Therefore, it always goes into the above if-clause, resulting insetupSSEConnection
being unreachable, ultimately never setting up an SSE build-notification connection properly.This fix checks if
this.endpoint
has a leading/
, if so it adds a leading/
onto theurl
variable for proper comparison.