Skip to content

fix(nf): Parallelized 'separate' external builds #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+30 −18
Open

fix(nf): Parallelized 'separate' external builds #955

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 30 additions & 18 deletions libs/native-federation-core/src/lib/core/build-for-federation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { bundleShared } from './bundle-shared';
import { FederationOptions } from './federation-options';
import { writeFederationInfo } from './write-federation-info';
import { writeImportMap } from './write-import-map';
import { logger } from '../utils/logger';

export interface BuildParams {
skipMappingsAndExposed: boolean;
Expand All @@ -35,11 +36,13 @@ export async function buildForFederation(
let artefactInfo: ArtefactInfo | undefined;

if (!buildParams.skipMappingsAndExposed) {
var start = process.hrtime();
artefactInfo = await bundleExposedAndMappings(
config,
fedOptions,
externals
);
logDuration(start, 'To bundle all mappings and exposed.');
}

const exposedInfo = !artefactInfo
Expand All @@ -50,6 +53,8 @@ export async function buildForFederation(
const { sharedBrowser, sharedServer, separateBrowser, separateServer } =
splitShared(config.shared);

var start = process.hrtime();

const sharedPackageInfoBrowser = await bundleShared(
sharedBrowser,
config,
Expand Down Expand Up @@ -82,6 +87,8 @@ export async function buildForFederation(
'node'
);

logDuration(start, 'To bundle all dependencies');

sharedPackageInfoCache = [
...sharedPackageInfoBrowser,
...sharedPackageInfoServer,
Expand Down Expand Up @@ -119,6 +126,11 @@ type SplitSharedResult = {
separateServer: Record<string, NormalizedSharedConfig>;
};

function logDuration(start: [number, number], msg: string) {
var [seconds, milliseconds] = process.hrtime(start);
logger.debug(`${seconds}s:${milliseconds.toFixed(3)}ms - ${msg}`);
}

function inferPackageFromSecondary(secondary: string): string {
const parts = secondary.split('/');
if (secondary.startsWith('@') && parts.length >= 2) {
Expand All @@ -134,24 +146,24 @@ async function bundleSeparate(
fedOptions: FederationOptions,
platform: 'node' | 'browser'
) {
const result: SharedInfo[] = [];
for (const key in separateBrowser) {
const shared = separateBrowser[key];
const packageName = inferPackageFromSecondary(key);
const filteredExternals = externals.filter(
(e) => !e.startsWith(packageName)
);
const record = { [key]: shared };
const buildResult = await bundleShared(
record,
config,
fedOptions,
filteredExternals,
platform
);
buildResult.forEach((item) => result.push(item));
}
return result;
const bundlePromises = Object.entries(separateBrowser).map(
async ([key, shared]) => {
const packageName = inferPackageFromSecondary(key);
const filteredExternals = externals.filter(
(e) => !e.startsWith(packageName)
);
return bundleShared(
{ [key]: shared },
config,
fedOptions,
filteredExternals,
platform
);
}
);

const buildResults = await Promise.all(bundlePromises);
return buildResults.flat();
}

function splitShared(
Expand Down