refactor(@angular/cli): separate the version command's analysis logic from logging #30813
+269
−147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from logging Refactors the `version` command's output generation for better readability and maintainability. This also allows other parts of the CLI to gather the version info programmatically, if needed. The key changes include: - Extracting the output formatting logic from the `run` method into a new private `formatVersionInfo` function. - Introducing a `VersionInfo` interface to provide a clear data structure for the version details. - Moving the ASCII art logo to a module-level constant to separate presentation from logic. - Relocating the `gatherVersionInfo` function, `VersionInfo` interface, and related constants to a new `version-info.ts` file to better organize the code.
clydin
added
the
action: review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the
versioncommand's output generation for better readability and maintainability. This also allows other parts of the CLI to gather the version info programmatically, if needed.The key changes include:
runmethod into a new privateformatVersionInfofunction.VersionInfointerface to provide a clear data structure for the version details.gatherVersionInfofunction,VersionInfointerface, and related constants to a newversion-info.tsfile to better organize the code.