Skip to content

refactor(@angular/build): improve error handling for unit-test builder setup #30945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 19, 2025

Conversation

clydin
Copy link
Member

@clydin clydin commented Aug 18, 2025

Error handling has been enhanced to provide more actionable feedback for common misconfigurations, such as an invalid buildTarget or a malformed test runner package.

The experimental unit-test builder will now pass through the progress option
to the build system if present. By default the progress value of the build
target will be used.

Closes #30865

clydin added 2 commits August 18, 2025 12:11
…r setup

Error handling has been enhanced to provide more actionable feedback for common misconfigurations, such as an invalid `buildTarget` or a malformed test runner package.
Refactors the Vitest test runner to improve code organization and separation of concerns.

The browser-specific helper functions (`findBrowserProvider`, `normalizeBrowserName`, and `setupBrowserConfiguration`) are moved from the main `executor.ts` file into a new, dedicated `browser-provider.ts` file.

This cleanup allows the main executor to focus solely on its primary responsibility of managing the test execution lifecycle, while properly encapsulating the browser setup logic in a single, co-located file.
@clydin clydin added the target: major This PR is targeted for the next major release label Aug 18, 2025
@clydin clydin force-pushed the unit-test/error-handling branch from 66f4607 to 793f102 Compare August 18, 2025 16:41
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Aug 18, 2025
…building

The experimental unit-test builder will now pass through the `progress` option
to the build system if present. By default the `progress` value of the build
target will be used.
@clydin clydin force-pushed the unit-test/error-handling branch from 793f102 to 5107c51 Compare August 18, 2025 17:51
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 19, 2025
@clydin clydin merged commit 0505f95 into angular:main Aug 19, 2025
53 of 55 checks passed
@clydin clydin deleted the unit-test/error-handling branch August 19, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/build target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng test does not support progress argument with vitest runner
2 participants