fix(google-maps): update right-click event to use contextmenu for Adv… #30523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SippieCup
requested review from
mmalerba and
wagnermaciel
and removed request for
a team
mmalerba
approved these changes
Feb 19, 2025
|
Thinking about this more, I believe google maps natively block the default context menu within the component, am I correct in that belief? Or should I be adding I don't understand google-maps & map-advanced-marker interactions enough to make the change within map-advanced-marker itself without some feedback. |
|
I am not sure about that. We have a page to test it in our dev app ( |
mmalerba
requested changes
Aug 11, 2025
SippieCup
force-pushed
the
fix-right-click-advanced-markers
branch
from
cee6bce to
3c2a592
Compare
SippieCup
force-pushed
the
fix-right-click-advanced-markers
branch
from
3c2a592 to
6186b1a
Compare
By rewriting the prototype of the advancedmarker and inject functionality for right clicking there.We have a cleaner and more native event management within the component and fix issues surrounding different ways contextmenu is supported across browsers.
SippieCup
force-pushed
the
fix-right-click-advanced-markers
branch
from
6186b1a to
f7cdfc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'rightclick' never triggers on advanced marker elements. nor within on gmp-click, as right-click events have been disabled for some reason on advanced markers within JS Maps.
This assumes that contextmenu is being opened via right clicking of a mouse, which is 99% of use cases. We can rename the emitter as well if deemed necessary to truly fit context, but I wanted to maintain backwards compatibility with and uniformity between the two.