Cleanup: Fix warnings and improve safety in BackupManager.kt#20345
Open
jatinfoujdar wants to merge 1 commit intoankidroid:mainfrom
Open
Cleanup: Fix warnings and improve safety in BackupManager.kt#20345jatinfoujdar wants to merge 1 commit intoankidroid:mainfrom
jatinfoujdar wants to merge 1 commit intoankidroid:mainfrom
Conversation
…nd ensure locale consistency in date formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
The goal of this PR is to resolve several Android Studio warnings and improve code safety in BackupManager.kt
. This is a contribution for the "Good First Issue" task designed for new contributors.
Fixes
Approach
Added Locale.US to SimpleDateFormat instances (legacyDateFormat and newDateFormat). This ensures that backup date formatting is consistent and doesn't depend on the device's system locale, which resolves a common "Implicitly using the default locale" warning.
How Has This Been Tested?
-
Manual Verification: I performed a manual review of the logic to ensure that safe calls and fallbacks maintain the original directory navigation behavior while preventing crashes.-
Code Review: Verified that all !! associated with listFiles() and parentFile in this file have been addressed.r or physical, etc)Learning (optional, can help others)
Describe the research stage
Links to blog posts, patterns, libraries or addons used to solve this problem
Checklist
Please, go through these checks before submitting the PR.