Added tests for export dialog options#20354
Open
KT-1114 wants to merge 1 commit intoankidroid:mainfrom
Open
Conversation
973b660 to
52bb863
Compare
52bb863 to
3c27971
Compare
Author
|
Hey sorry for this little mess. At first I forgot to redo the changes I made in order to test the tests and then after finding that my push failed the tests I panicked and pushed without adding the change. I didn't test all these tests locally as my changes were little and I tested the tests, lesson learnt, will take care of this next time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds tests for export options available on export dialogue for exporting as Anki Collection Package and as Anki Deck Package.
Fixes
@NeedsTest) #13283Approach
Implemented tests check for the expected visibility and values of the options when user tires to export as Anki Deck or as Anki Collection packages.
How Has This Been Tested?
I modified the default values for the visibility of the options and values for the check boxes in the xml file. Then ran the tests to validate the logic.
Learning (optional, can help others)
I learnt how we can automate test and make sure our that if futures changes do something out of order then we can alert ourselves without the user facing any issue. I learnt that isolated parts can also be checked without depending on parts which a user would need to use while using an actual app.
Checklist