Fix cloze numbering in Instant Note when text already contains clozes

[Alok-Silswal]

Purpose / Description

Instant Note was not handling cloze numbering properly when the shared text already had clozes like {{c1::}}, {{c2::}}, etc.

This PR fixes it.

Fixes

• Fixes Adding additional clozes doesn't work properly for Instant Cards in AnkiDroid #20350

Approach

• The fix ensures that the cloze counter is derived from the actual text instead of assuming it always starts from 1.

• Mode switching was simplified so that changing modes does not change the counter by itself.

Flow Summary:

setClozeFieldText(text)
        ↓
syncClozeState(text)
        ↓
Extract existing cloze indices
        ↓
Update intClozeList
        ↓
Set counter = max(existing) + 1

During Selection:

If INCREMENT ([...]+):
   - Use current counter
   - Then increment counter

If NO_INCREMENT ([...]):
   - Use highest existing cloze index
   - Do not change counter 

How Has This Been Tested?

• Verified that existing unit tests pass (InstantEditorViewModelTest.kt).

• Tested on my phone (Android 14, Xiaomi / HyperOS) using a debug build.

Used the following two texts for testing:

This is the {{c1::first cloze}}. This should be the second cloze.

This is the {{c1::first cloze}}. This should be the {{c2::second cloze}}. Similarly, this one as {{c3::third cloze}}.

Two screen recording attached as evidence.

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

Cloze_fix_evidence_1.mp4

Cloze_fix_evidence_2.mp4

[criticalAY]

The seems LLM generated, comments are still there

[criticalAY]

Doc can be improved

[Alok-Silswal]

Doc can be improved

" Make cloze counter and intClozeList consistent with actual text. "

How about this one?

[criticalAY]

We can do without intermediate list allocation

[Alok-Silswal]

Understood! We will allocate directly then.

---

intClozeList.clear()

var max = 0
clozePattern.findAll(text).forEach {
    val value = it.groups[2]?.value?.toIntOrNull()
    if (value != null) {
        intClozeList.add(value)
        if (value > max) max = value
    }
}

_currentClozeNumber.value = max + 1

Is this approach correct?

[Alok-Silswal]

comments are still there

I had over-explained the details. Simplified it now.

[Alok-Silswal]

Improved the doc and removed intermediate list allocation.

[criticalAY]

I had over-explained the details. Simplified it now.

Can I confirm you've read our AI policy: https://github.com/ankidroid/Anki-Android/blob/main/AI_POLICY.md? The code you provided was AI-generated

[Alok-Silswal]

Can I confirm you've read our AI policy: https://github.com/ankidroid/Anki-Android/blob/main/AI_POLICY.md? The code you provided was AI-generated

I have read it now.

Code logic was mine (POV: I do DSA regularly), but I used AI for implementation and for polishing PR description also in the first one(whose words were also mine).

Now I understand that up till 3 PR we cannot use AI in any form. This makes this PR ineligible.

Shall I rework this PR or close it to submit a new one?

[Alok-Silswal]

I checked other PRs with same issue and seems like this will not work.