test: verify login redirection on HTTP 429 using Robolectric#20361
Open
largeblueberry wants to merge 1 commit intoankidroid:mainfrom
Open
test: verify login redirection on HTTP 429 using Robolectric#20361largeblueberry wants to merge 1 commit intoankidroid:mainfrom
largeblueberry wants to merge 1 commit intoankidroid:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
This pr is test for user is not redirected to login/signup if they are logged in to AnkiWeb
Fixes
None
Approach
Structure Refactoring for Testability:
Test code strategy:
spyWebClientbefore callingstart()andresume().isLoggedInToAnkiWebTest isolation:
Used the
saveControllerForCleanupfunction in the RobolectricTest file to prevent the previous test from being transferred to the next test.How Has This Been Tested?
Learning (optional, can help others)
RobolectricTestChecklist
Please, go through these checks before submitting the PR.