Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Merkle tree implementation based on the Zcash/MASP implementation (from a month ago). Some notes:
--gas-report
is used to measure gas usage, this implementation uses 30% less gas than the OpenZeppelin based implementation according to the benchmarks that were used to select the latter.test_execute_mint_transfer_burn
is the only new failing test. Its failure is aNonExistingRoot
failure and is probably due it using Merkle roots from eager Merkle tree expansions.