refactor: function order in ProtocolAdapter.sol #370
+72
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that if function foo uses bar then foo is positioned higher than bar.
murisi
approved these changes
Oct 3, 2025
heueristik
reviewed
Oct 6, 2025
There was a problem hiding this comment.
I am in favor of these optimizations. However, we should be careful to not move code around while the audit is ongoing, to not create extra work for auditors / when applying audit findings. Maybe we can bundle up these changes and apply them once the audit is finished
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that if function
foousesbarthenfoois positioned higher thanbar.