Skip to content

Bugfix: Fix commit timeout type failure issue #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Bugfix: Fix commit timeout type failure issue #670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50c69c4
Bugfix: Fix commit timeout type failure issue
rohitthakur2590 Oct 3, 2024
101d336
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 3, 2024
09e6ec8
Merge branch 'main' into type_commit_timer
roverflow Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelogs/fragments/confirm_commit_error_fix.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
bugfixes:
- Confirmed commit results in Failure becuase of wrongly provided type
(https://github.com/ansible-collections/ansible.netcommon/issues/551)
4 changes: 2 additions & 2 deletions plugins/modules/netconf_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@

"""

from ansible.module_utils._text import to_text
from ansible.module_utils._text import to_native, to_text
from ansible.module_utils.basic import AnsibleModule
from ansible.module_utils.connection import Connection, ConnectionError

Expand Down Expand Up @@ -488,7 +488,7 @@ def main():
source = module.params["source_datastore"]
delete = module.params["delete"]
confirm_commit = module.params["confirm_commit"]
confirm = module.params["confirm"]
confirm = to_text(module.params["confirm"], error="surrogate_or_strict")
validate = module.params["validate"]
save = module.params["save"]
filter = module.params["get_filter"]
Expand Down
Loading