Skip to content

Conversation

felixfontein
Copy link
Collaborator

@felixfontein felixfontein commented Jun 8, 2021

@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #23 (87f0217) into main (d4ab04f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage   96.43%   96.43%           
=======================================
  Files          91       91           
  Lines        6373     6373           
  Branches      758      758           
=======================================
  Hits         6146     6146           
  Misses        163      163           
  Partials       64       64           
Flag Coverage Δ
integration 36.21% <ø> (ø)
sanity 31.13% <ø> (ø)
units 95.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/doc_fragments/filters.py 100.00% <ø> (ø)
plugins/doc_fragments/hetzner.py 100.00% <ø> (ø)
plugins/doc_fragments/hosttech.py 100.00% <ø> (ø)
plugins/doc_fragments/inventory_records.py 100.00% <ø> (ø)
plugins/doc_fragments/module_record.py 100.00% <ø> (ø)
plugins/doc_fragments/module_record_info.py 100.00% <ø> (ø)
plugins/doc_fragments/module_record_set.py 100.00% <ø> (ø)
plugins/doc_fragments/module_record_set_info.py 100.00% <ø> (ø)
plugins/doc_fragments/module_record_sets.py 100.00% <ø> (ø)
plugins/doc_fragments/module_zone_info.py 100.00% <ø> (ø)
... and 10 more

@felixfontein
Copy link
Collaborator Author

The failing sanity tests are due to a bug in ansible-test in stable-2.10 (ansible/ansible#75272) and potentially also 2.9.

@felixfontein felixfontein force-pushed the use-semantic-markup branch 5 times, most recently from 1914e49 to 4e081f2 Compare July 21, 2021 20:13
@felixfontein felixfontein force-pushed the use-semantic-markup branch 2 times, most recently from 19bcba6 to 3067232 Compare August 4, 2021 19:41
@felixfontein
Copy link
Collaborator Author

CI should pass once ansible/ansible#75405 is merged.

@felixfontein felixfontein force-pushed the use-semantic-markup branch 2 times, most recently from ed32ded to 2f803d5 Compare August 11, 2021 06:50
@felixfontein felixfontein force-pushed the use-semantic-markup branch 2 times, most recently from 746e646 to 7cbb68d Compare August 15, 2021 14:02
@felixfontein
Copy link
Collaborator Author

recheck

@felixfontein felixfontein force-pushed the use-semantic-markup branch 3 times, most recently from ffccd59 to 48d6106 Compare December 2, 2022 12:57
@felixfontein felixfontein force-pushed the use-semantic-markup branch 2 times, most recently from af0ccbc to 2f0c80c Compare December 7, 2022 18:54
@felixfontein felixfontein changed the title [WIP] Use semantic markup Use semantic markup Mar 9, 2023
@felixfontein
Copy link
Collaborator Author

I rebased since antsibull-docs now supports semantic markup out of the box.

@felixfontein felixfontein force-pushed the use-semantic-markup branch 2 times, most recently from 86483ab to c686298 Compare March 23, 2023 18:38
@felixfontein
Copy link
Collaborator Author

I rebased again to remove the usage of my ansible-core branch since the associated PR has been merged 🎉

So the only thing this PR is waiting for is a review (at least by myself, to see whether I actually caught all markup to convert, and did it correctly), and that the last Ansible 7 release is out so that the Ansible 7 docsite (which doesn't understand semantic markup) for this collection won't be defaced.

@felixfontein felixfontein marked this pull request as draft March 27, 2023 20:17
@felixfontein felixfontein force-pushed the use-semantic-markup branch from 4ea437a to 9487c00 Compare April 4, 2023 06:18
@felixfontein
Copy link
Collaborator Author

Ansible 8.0.0 will be released on 2023-06-06 or 2023-05-30 (see https://docs.ansible.com/ansible/devel/roadmap/COLLECTIONS_8.html#release-schedule), so the last Ansible 7.x.y release should be on 2023-06-21. Which means we can finally merge and release this around 2023-06-22 🎉

@felixfontein felixfontein force-pushed the use-semantic-markup branch from ae80165 to 75039c2 Compare June 19, 2023 09:13
@felixfontein felixfontein marked this pull request as ready for review June 22, 2023 04:56
@felixfontein felixfontein merged commit dc4ce80 into ansible-collections:main Jun 22, 2023
@felixfontein felixfontein deleted the use-semantic-markup branch June 22, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant