[Enabler][2147-2149]update_job_modules_interfaces #2208

AndreMarcel99 · 2025-07-16T22:10:12Z

SUMMARY

Change jobs utilities and interfaces for new 2.0 version.

Fixes #2147 and #2149

ISSUE TYPE

Enabler Pull Request

COMPONENT NAME

Create a new flag for not found changes as a dictionary values to ensure change is properly returned.

ADDITIONAL INFORMATION

Add validation for all test cases.

richp405

Minor comment: changelog fragment has ticket 2204 and pull 2204. I'm not sure on ticket number, but the pull request should be 2208.

richp405 · 2025-07-21T15:07:54Z

changelogs/fragments/2204-Update_zos_job_query_module.yml

@@ -1,3 +1,3 @@
 breaking_changes:
-  - zos_job_query - Return value ``message`` is deprecated in favor of ``msg``. Return value ``steps`` are no longer under `` but is now included under jobs.
+  - zos_job_query - Return value ``message`` is deprecated in favor of ``msg``. Return value ``steps`` are no longer under ``ret_code`` but is now included under jobs.
    (https://github.com/ansible-collections/ibm_zos_core/pull/2204).


Shouldn't this be ...pull/2208 ?

Is the other changelog, this is form the previous PR of changes of zos_job_query, but I realize I miss one problem

fernandofloresg

Requested few small changes for the changelog fragment

changelogs/fragments/2208_update_job_modules_interfaces.yml

fernandofloresg · 2025-08-01T17:25:23Z

changelogs/fragments/2208_update_job_modules_interfaces.yml

+  - zos_job_output - Interface value ``ddname`` is substitute for ``dd_name``, but ``ddname`` is an alias. Return value ``changed`` is always retun, ``steps`` are no longer under `ret_code`
+    but is now included under `jobs`. Return value ``ddnames`` replaced by ``dds`` and value ``ddname`` under ``ddnames`` is replace by ``dd_name``.
+    (https://github.com/ansible-collections/ibm_zos_core/pull/2208).
+  - zos_job_submit - Interface value ``location`` is replace for ``remote_src`` in a bool value and ``wait_time_s`` ir replace for ``wait_time``. 


Suggested change

- zos_job_submit - Interface value ``location`` is replace for ``remote_src`` in a bool value and ``wait_time_s`` ir replace for ``wait_time``.

- zos_job_submit - Option name ``location`` is replaced for ``remote_src`` and now its behavior is defined by a bool value and ``wait_time_s`` is replaced for ``wait_time``.

fernandofloresg · 2025-08-01T17:30:25Z

changelogs/fragments/2208_update_job_modules_interfaces.yml

+    but is now included under `jobs`. Return value ``ddnames`` replaced by ``dds`` and value ``ddname`` under ``ddnames`` is replace by ``dd_name``.
+    (https://github.com/ansible-collections/ibm_zos_core/pull/2208).
+  - zos_job_submit - Interface value ``location`` is replace for ``remote_src`` in a bool value and ``wait_time_s`` ir replace for ``wait_time``. 
+    Return value ``ddnames`` replaced by ``dds`` and value ``ddname`` under ``ddnames`` is replace by ``dd_name``. Return values ``system``, ``subsystem``, ``cpu_time``, ``execution_node``


Suggested change

Return value ``ddnames`` replaced by ``dds`` and value ``ddname`` under ``ddnames`` is replace by ``dd_name``. Return values ``system``, ``subsystem``, ``cpu_time``, ``execution_node``

Return value ``ddnames`` replaced by ``dds`` and value ``ddname`` under ``ddnames`` is replaced by ``dd_name``. Return values ``system``, ``subsystem``, ``cpu_time``, ``execution_node``

plugins/modules/zos_job_submit.py

changelogs/fragments/2208_update_job_modules_interfaces.yml

Co-authored-by: Fernando Flores <[email protected]>

AndreMarcel99 · 2025-08-01T21:08:03Z

fernandofloresg

LGTM

rexemin · 2025-08-01T15:37:09Z

changelogs/fragments/2208_update_job_modules_interfaces.yml

@@ -0,0 +1,13 @@
+breaking_changes:
+  - zos_job_output - Interface value ``ddname`` is substitute for ``dd_name``, but ``ddname`` is an alias. Return value ``changed`` is always retun, ``steps`` are no longer under `ret_code`


Suggested change

- zos_job_output - Interface value ``ddname`` is substitute for ``dd_name``, but ``ddname`` is an alias. Return value ``changed`` is always retun, ``steps`` are no longer under `ret_code`

- zos_job_output - Option ``ddname`` is substituted for ``dd_name``, but retaining ``ddname`` as an alias. Return field ``changed`` is now always returned, ``steps`` is no longer under `ret_code`

rexemin · 2025-08-01T15:37:40Z

changelogs/fragments/2208_update_job_modules_interfaces.yml

@@ -0,0 +1,13 @@
+breaking_changes:
+  - zos_job_output - Interface value ``ddname`` is substitute for ``dd_name``, but ``ddname`` is an alias. Return value ``changed`` is always retun, ``steps`` are no longer under `ret_code`
+    but is now included under `jobs`. Return value ``ddnames`` replaced by ``dds`` and value ``ddname`` under ``ddnames`` is replace by ``dd_name``.


Suggested change

but is now included under `jobs`. Return value ``ddnames`` replaced by ``dds`` and value ``ddname`` under ``ddnames`` is replace by ``dd_name``.

but is now included under `jobs`. Return field ``ddnames`` is replaced by ``dds`` and field ``ddname`` under ``ddnames`` is replaced by ``dd_name``.

changelogs/fragments/2204-Update_zos_job_query_module.yml

rexemin · 2025-08-01T15:58:20Z

changelogs/fragments/2208_update_job_modules_interfaces.yml

+  - zos_job_output - Interface value ``ddname`` is substitute for ``dd_name``, but ``ddname`` is an alias. Return value ``changed`` is always retun, ``steps`` are no longer under `ret_code`
+    but is now included under `jobs`. Return value ``ddnames`` replaced by ``dds`` and value ``ddname`` under ``ddnames`` is replace by ``dd_name``.
+    (https://github.com/ansible-collections/ibm_zos_core/pull/2208).
+  - zos_job_submit - Interface value ``location`` is replace for ``remote_src`` in a bool value and ``wait_time_s`` ir replace for ``wait_time``. 


Suggested change

- zos_job_submit - Interface value ``location`` is replace for ``remote_src`` in a bool value and ``wait_time_s`` ir replace for ``wait_time``.

- zos_job_submit - Option ``location`` is replaced for ``remote_src``, a boolean value and ``wait_time_s`` is replaced for ``wait_time``.

rexemin · 2025-08-01T15:59:29Z

changelogs/fragments/2208_update_job_modules_interfaces.yml

+    but is now included under `jobs`. Return value ``ddnames`` replaced by ``dds`` and value ``ddname`` under ``ddnames`` is replace by ``dd_name``.
+    (https://github.com/ansible-collections/ibm_zos_core/pull/2208).
+  - zos_job_submit - Interface value ``location`` is replace for ``remote_src`` in a bool value and ``wait_time_s`` ir replace for ``wait_time``. 
+    Return value ``ddnames`` replaced by ``dds`` and value ``ddname`` under ``ddnames`` is replace by ``dd_name``. Return values ``system``, ``subsystem``, ``cpu_time``, ``execution_node``


Suggested change

Return value ``ddnames`` replaced by ``dds`` and value ``ddname`` under ``ddnames`` is replace by ``dd_name``. Return values ``system``, ``subsystem``, ``cpu_time``, ``execution_node``

Return field ``ddnames`` is replaced by ``dds`` and field ``ddname`` under ``ddnames`` is replaced by ``dd_name``. Return fields ``system``, ``subsystem``, ``cpu_time``, ``execution_node``

plugins/modules/zos_job_submit.py

rexemin · 2025-08-01T23:08:54Z

changelogs/fragments/2208_update_job_modules_interfaces.yml

+    (https://github.com/ansible-collections/ibm_zos_core/pull/2208).
+  - zos_job_submit - Interface value ``location`` is replace for ``remote_src`` in a bool value and ``wait_time_s`` ir replace for ``wait_time``. 
+    Return value ``ddnames`` replaced by ``dds`` and value ``ddname`` under ``ddnames`` is replace by ``dd_name``. Return values ``system``, ``subsystem``, ``cpu_time``, ``execution_node``
+    and ``origin node`` is no longer returned. Now all values are retuned under jobs exception for changed.


Suggested change

and ``origin node`` is no longer returned. Now all values are retuned under jobs exception for changed.

and ``origin node`` are no longer returned. Every other field is now always returned under ``jobs``.

Co-authored-by: Alex Moreno <[email protected]>

Co-authored-by: Fernando Flores <[email protected]>

Co-authored-by: Alex Moreno <[email protected]>

fernandofloresg

LGTM!

changelogs/fragments/2208_update_job_modules_interfaces.yml

Co-authored-by: Alex Moreno <[email protected]>

fernandofloresg

Looks good to me, thanks for updating this

AndreMarcel99 and others added 8 commits July 14, 2025 12:26

Test

cc5ee6c

Modify action job submit

2f7a1c4

Replace structure for empty jobs

1972bd6

Modify structure

47510bc

Modify test to properly test new interface

e9994da

Modify test on base of job submit new interface

75b09f7

Be alignt

f21e73e

Modify job submit

33f8a0f

AndreMarcel99 changed the title ~~Enabler/2147 2149/update job modules interface~~ [Enabler][2147-2149]update_job_modules_interfaces Jul 16, 2025

André Marcel Gutiérrez Benítez added 7 commits July 16, 2025 16:38

Add fragment

0d46bdc

Better fragment

84b4292

Update documentation

ade2f0b

Fix commit

cebe0b9

Fix documentation

41e9653

Keep documentation

3b5ee97

Replace job submit

0ec0660

AndreMarcel99 marked this pull request as ready for review July 17, 2025 20:46

Fix sanity

8886ca4

AndreMarcel99 requested review from richp405, fernandofloresg, rexemin and surendrababuravella July 17, 2025 21:00

Fix sanity

49f7997

richp405 previously approved these changes Jul 21, 2025

View reviewed changes

André Marcel Gutiérrez Benítez added 2 commits August 1, 2025 11:57

Return values

4d8102c

Return values to module

14702c1

AndreMarcel99 dismissed richp405’s stale review via 14702c1 August 1, 2025 17:57

Return values to test suite and empty response

0327d58

fernandofloresg requested changes Aug 1, 2025

View reviewed changes

Update changelogs/fragments/2208_update_job_modules_interfaces.yml

b4ca89d

Co-authored-by: Fernando Flores <[email protected]>

Validate test case

afc2bf5

AndreMarcel99 requested review from richp405 and fernandofloresg August 1, 2025 21:08

fernandofloresg previously approved these changes Aug 1, 2025

View reviewed changes

rexemin requested changes Aug 1, 2025

View reviewed changes

Update changelogs/fragments/2204-Update_zos_job_query_module.yml

a39b28d

Co-authored-by: Alex Moreno <[email protected]>

AndreMarcel99 dismissed fernandofloresg’s stale review via a39b28d August 1, 2025 23:17

AndreMarcel99 and others added 4 commits August 1, 2025 17:18

Update plugins/modules/zos_job_submit.py

8030ad2

Co-authored-by: Fernando Flores <[email protected]>

Update plugins/modules/zos_job_submit.py

b70786b

Co-authored-by: Fernando Flores <[email protected]>

Update plugins/modules/zos_job_submit.py

c4e9db8

Co-authored-by: Alex Moreno <[email protected]>

Update plugins/modules/zos_job_submit.py

d8da79d

Co-authored-by: Alex Moreno <[email protected]>

AndreMarcel99 requested review from rexemin and fernandofloresg August 1, 2025 23:21

richp405 previously approved these changes Aug 4, 2025

View reviewed changes

fernandofloresg previously approved these changes Aug 4, 2025

View reviewed changes

rexemin requested changes Aug 4, 2025

View reviewed changes

changelogs/fragments/2208_update_job_modules_interfaces.yml Outdated Show resolved Hide resolved

changelogs/fragments/2208_update_job_modules_interfaces.yml Outdated Show resolved Hide resolved

changelogs/fragments/2208_update_job_modules_interfaces.yml Outdated Show resolved Hide resolved

Update changelogs/fragments/2208_update_job_modules_interfaces.yml

0b07a67

Co-authored-by: Alex Moreno <[email protected]>

AndreMarcel99 dismissed stale reviews from fernandofloresg and richp405 via 0b07a67 August 4, 2025 21:00

AndreMarcel99 and others added 2 commits August 4, 2025 15:00

Update changelogs/fragments/2208_update_job_modules_interfaces.yml

68cd698

Co-authored-by: Alex Moreno <[email protected]>

Update changelogs/fragments/2208_update_job_modules_interfaces.yml

5076094

Co-authored-by: Alex Moreno <[email protected]>

AndreMarcel99 requested a review from rexemin August 4, 2025 21:00

rexemin approved these changes Aug 4, 2025

View reviewed changes

AndreMarcel99 requested review from fernandofloresg and richp405 August 4, 2025 22:59

fernandofloresg approved these changes Aug 5, 2025

View reviewed changes

fernandofloresg merged commit 3e7ec31 into dev Aug 5, 2025
5 checks passed

fernandofloresg deleted the enabler/2147-2149/update_job_modules_interface branch August 5, 2025 16:05

fernandofloresg mentioned this pull request Aug 6, 2025

[Enhancement] Update zos_job_submit module interface #2149

Closed

5 tasks

	- zos_job_submit - Interface value ``location`` is replace for ``remote_src`` in a bool value and ``wait_time_s`` ir replace for ``wait_time``.
	- zos_job_submit - Option name ``location`` is replaced for ``remote_src`` and now its behavior is defined by a bool value and ``wait_time_s`` is replaced for ``wait_time``.

	Return value ``ddnames`` replaced by ``dds`` and value ``ddname`` under ``ddnames`` is replace by ``dd_name``. Return values ``system``, ``subsystem``, ``cpu_time``, ``execution_node``
	Return value ``ddnames`` replaced by ``dds`` and value ``ddname`` under ``ddnames`` is replaced by ``dd_name``. Return values ``system``, ``subsystem``, ``cpu_time``, ``execution_node``

		@@ -0,0 +1,13 @@
		breaking_changes:
		- zos_job_output - Interface value ``ddname`` is substitute for ``dd_name``, but ``ddname`` is an alias. Return value ``changed`` is always retun, ``steps`` are no longer under `ret_code`

	- zos_job_output - Interface value ``ddname`` is substitute for ``dd_name``, but ``ddname`` is an alias. Return value ``changed`` is always retun, ``steps`` are no longer under `ret_code`
	- zos_job_output - Option ``ddname`` is substituted for ``dd_name``, but retaining ``ddname`` as an alias. Return field ``changed`` is now always returned, ``steps`` is no longer under `ret_code`

	but is now included under `jobs`. Return value ``ddnames`` replaced by ``dds`` and value ``ddname`` under ``ddnames`` is replace by ``dd_name``.
	but is now included under `jobs`. Return field ``ddnames`` is replaced by ``dds`` and field ``ddname`` under ``ddnames`` is replaced by ``dd_name``.

	- zos_job_submit - Interface value ``location`` is replace for ``remote_src`` in a bool value and ``wait_time_s`` ir replace for ``wait_time``.
	- zos_job_submit - Option ``location`` is replaced for ``remote_src``, a boolean value and ``wait_time_s`` is replaced for ``wait_time``.

	Return value ``ddnames`` replaced by ``dds`` and value ``ddname`` under ``ddnames`` is replace by ``dd_name``. Return values ``system``, ``subsystem``, ``cpu_time``, ``execution_node``
	Return field ``ddnames`` is replaced by ``dds`` and field ``ddname`` under ``ddnames`` is replaced by ``dd_name``. Return fields ``system``, ``subsystem``, ``cpu_time``, ``execution_node``

	and ``origin node`` is no longer returned. Now all values are retuned under jobs exception for changed.
	and ``origin node`` are no longer returned. Every other field is now always returned under ``jobs``.

[Enabler][2147-2149]update_job_modules_interfaces #2208

[Enabler][2147-2149]update_job_modules_interfaces #2208

Uh oh!

Conversation

AndreMarcel99 commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

Uh oh!

richp405 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fernandofloresg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AndreMarcel99 commented Aug 1, 2025

Uh oh!

fernandofloresg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fernandofloresg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fernandofloresg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

AndreMarcel99 commented Jul 16, 2025 •

edited

Loading