[Enabler][2208]Adopt_generation_data_group_generations #2365
Conversation
AndreMarcel99
changed the title
AndreMarcel99
requested review from
Rohitcodes28,
fernandofloresg,
mayankmani-sde,
rexemin,
richp405 and
surendrababuravella
| @@ -0,0 +1,13 @@ | |||
| minor_changes: | |||
There was a problem hiding this comment.
Unfortunately, this time this will have to be trivial this time since we will announce 1.4.0 in one announcement line, so no need to show this to the general public.
plugins/module_utils/data_set.py
Outdated
| generations = gdg.generations() | ||
| gds = generations[rel_generation - 1] | ||
| generations = gdg.generations | ||
| # On 1.4 zoau version if you give 0 or -1 go to proper generation |
There was a problem hiding this comment.
This comment is confusing, could you rephrase it or remove it?
plugins/modules/zos_mvs_raw.py
Outdated
| return str(datasets.create(dataset, type).name), "shr" | ||
| else: | ||
| return str(datasets.create(dataset, "seq").name), "shr" | ||
| return dataset, "new" |
There was a problem hiding this comment.
How this change will affect current behavior? if user specifies data set type as "PDS" will this default it to "seq" or other type?
There was a problem hiding this comment.
or is the type being considered when executing mvs_cmd? I couldn't find the line where type is considered
There was a problem hiding this comment.
For the new approach of gdg will take the base of the gdg set on the creation.
|
fernandofloresg
added
the
Do not Merge
|
Added no merge label, waiting for SPS pipeline screenshots |
|
fernandofloresg
deleted the
enabler/2208/adapat_GenerationDataGroupView_generations
branch
SUMMARY
Fixes new adoption of gdgs utilities from ZOAU 1.4.0
Fixes #2208
ISSUE TYPE
ADDITIONAL INFORMATION