AAP-58019: Added token auth info to Terraform Provider - DO NOT BACKPORT UNTIL RELEASE

[jonquilwilliams]

https://issues.redhat.com/browse/AAP-58019

Preview: https://jonquilwilliams.github.io/aap-builds/terraform-aap-getting-started-AAP-58019-2025-11-11.html

[dleehr]

Minor suggestion around best practices for credentials needed for configuration.

[dleehr]

I believe this example comes from our registry docs https://registry.terraform.io/providers/ansible/aap/latest/docs#example-usage, and have been thinking about we demonstrate best practices around tokens/passwords.

As a best practice we should not encourage putting a token (or password - anything secret) directly into a file like this since these files get committed to version control and shared. Putting secrets in them is just asking for trouble. We should make sure and that users are aware of that, and recommend using the AAP_TOKEN environment variable instead of putting a credential directly in the file.

The AWS provider has a pretty good warning that calls this out, so I suggest we include something like that in our docs (and what we put on the registry). From https://registry.terraform.io/providers/hashicorp/aws/latest/docs#provider-configuration:

Warning:
Hard-coded credentials are not recommended in any Terraform configuration and risks secret leakage should this file ever be committed to a public version control system.

Suggested change

	token = "my-aap-token" # Also supports AAP_TOKEN environment variable
	token = "my-aap-token" # Do not record credentials directly in Terraform configuration. Provide your token via the AAP_TOKEN environment variable.