-
Notifications
You must be signed in to change notification settings - Fork 6
AAP-43385: On-prem: Automate provision and related configuration changes #575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@rooftopcellist @rcarrillocruz You remain the most knowledgeable about operator development and therefore your review is welcome... you'll no doubt have some involvement with this and related works if and when it gets downstreamed (in some form or other) and so "early sight" won't do anybody any harm either. |
Operator wise I see where this change is going. Just thinking out loud: Would it be too crazy to ship MCP-component as a sidecar in component and expose it via an endpoint in the component nginx? |
Hi @rcarrillocruz we are to conduct a SDP for The MCP servers in this PR are added as sidecars in the main Chatbot All network traffic between Anyway.. this is a draft, SDP illustrating in essence this PR to be conducted. It's all likely to change 🤣 |
Awesome, I thought the LlamaStack SDP was about downstreamification of it. |
What I meant by sidecars I meant as a service running in the upstream component project. But yeah, that's better discussed in the MCP architecture SDP, let's not continue this convo here. |
a0f0b39
to
2706481
Compare
b724e97
to
fa077bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff looks good. I did not get to deploy and poke at it, but I think we can merge and let it harden in downstream builds and test more there.
Jira Issue: https://issues.redhat.com/browse/AAP-43385
Description
This PR adds support for deploying
ansible-chatbot-stack
with our Operator.It will automatically provision and register various MCP Servers along with
llama-stack
as necessary.The behavior is defined by additional settings in
chatbot_config_secret
:Testing
aap_gateway_url
andaap_controller_url
.llama-stack
NOTE: We currently don't support AAP Gateway MCP Server due to issues relating to authentication tokens.
NOTE: It's difficult to test with MCP Server integration. It requires an AAP 2.6 instance for authentication.
CRO (tested with minikube)
Chatbot secret (without MCP)
Chatbot secret (with MCP)
Scenarios tested
As above.
Production deployment