-
Notifications
You must be signed in to change notification settings - Fork 100
Allow downstreams to enforce that the ansible_core ref must have a version specifier #743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd much rather see this validation done in the UserDefinition.validate()
method where everything else is validated.
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested an additional test for complete code coverage, and a spelling correction. Otherwise, LGTM.
Co-authored-by: David Shrewsbury <[email protected]>
I've accepted the review changes, looks like there is at minimum a linting issue which I'll resolve though. I just want to note that the resolution of these things doesn't mean this needs merged. This is an idea, which we ultimately need to decide whether we want it or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but not merging until we decide we actually want this.
This PR allows downstreams to patch
REQUIRE_ANSIBLE_CORE_PIN
inconstants.py
to a value ofTrue
to force EE definitions to contain a pin for theansible-core
specification.This would help ensure that users building custom EEs would have to put thought into the version of ansible-core that they intend to be using, without unexpected upgrades in the building process pulling in a newer version they have not tested against.
No evaluation of the pin is done, this is a minor safety net.