-
Couldn't load subscription status.
- Fork 14
AAP-55681: Bump lightspeed-core-stack and lightspeed-providers #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
AAP-55681: Bump lightspeed-core-stack and lightspeed-providers #107
Conversation
bump lightspeed-providers to 0.1.6
3d164ad to
37d526e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looking good!! 👍
But can't test because of can't pull from quay....
$ podman login quay.io
Authenticating with existing credentials for quay.io
Existing credentials are invalid, please enter valid username and password
Username (romartin):
Password:
Error: authenticating creds for "quay.io": too many requests to registry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are looking great, thanks @de1987
I have been able to test it quickly, in local, and I see a few things needs re-visiting before merging:
-
I still need tp riun a few AAP RAG & Inventory Gen. tests to ensure quality
-
Noticed slower inference times using LSC 0.3.0. I have to do more tests and compare with previous LSC versions anyway... may not block the PR, but we have to guarantee quality but also performance, otherwise let LSC team know
-
Please double check provider_id updates, after changes, as I see warning like:
WARNING 2025-10-27 21:47:34,406 llama_stack.core.routing_tables.common:257 core::routing_tables: WARNING: model identifier 'granite-3.3-8b-instruct'
not found in routing table. Falling back to searching in all providers. This is only for backwards compatibility and will stop working soon.
Migrate your calls to use fully scoped `provider_id/model_id` names.
Thanks!
| model_type: embedding | ||
| - metadata: {} | ||
| model_id: ${env.GEMINI_INFERENCE_MODEL:=gemini/gemini-2.5-flash} | ||
| model_id: ${env.GEMINI_INFERENCE_MODEL:=gemini-2.5-flash} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please redo this change as gemini model id works like this
| model_id: ${env.GEMINI_INFERENCE_MODEL:=gemini-2.5-flash} | |
| model_id: ${env.GEMINI_INFERENCE_MODEL:=gemini/gemini-2.5-flash} |
| model_id: ${env.GEMINI_INFERENCE_MODEL:=gemini-2.5-flash} | ||
| provider_id: gemini | ||
| provider_model_id: gemini/gemini-2.5-flash | ||
| provider_model_id: gemini-2.5-flash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please redo this change also or set it to null
|
@romartin that warning is not due to gemini having been changed, but to many other model ids. I think redo back that gemeni changes and we will be ready to merge |
| llama-stack==0.2.16 | ||
| llama-stack-client==0.2.16 | ||
| llama-stack==0.2.22 | ||
| llama-stack-client==0.2.23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why llama-stack-client version is different ?
it should be the same as llama-stack
https://github.com/lightspeed-core/lightspeed-stack/blob/main/pyproject.toml#L32C6-L32C24
Jira Issue: AAP-55681
Description
To support the 3rd party models it's required to:
lightspeed-core-stackto 0.3.0lightspeed-providersto 0.1.6Testing
Steps to test
make cleanmake runScenarios tested
I run the chatbox locally with Granite 3.3 and asked at least 20 questions about AAP, playbooks, how to automate things... All the responses were as expected.
Production deployment