Correct schema $id #21
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schema $id must point to a JSON fine that can be downloaded. Previous one was a github webside link that cannot be used. This is critical as JSON schema tools will try to update the schema using its $id.
| { | ||
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "$id": "https://github.com/ansible/pattern-service/blob/main/specifications/pattern_specification.json", | ||
| "$id": "https://raw.githubusercontent.com/ansible/pattern-service/refs/heads/main/specifications/pattern_specification.json", |
There was a problem hiding this comment.
The raw GitHub URL should use the branch name directly rather than ‘refs/heads/main’. For example:
"$id": "https://raw.githubusercontent.com/ansible/pattern-service/main/specifications/pattern_specification.json",
Suggested change
| "$id": "https://raw.githubusercontent.com/ansible/pattern-service/refs/heads/main/specifications/pattern_specification.json", | |
| "$id": "https://raw.githubusercontent.com/ansible/pattern-service/main/specifications/pattern_specification.json", |
Copilot uses AI. Check for mistakes.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schema $id must point to a JSON fine that can be downloaded. Previous one was a github website link that cannot be used. This is critical as JSON schema tools will try to update the schema using its $id.
Example of correctly configured
$id: https://github.com/ansible/ansible-lint/blob/main/src/ansiblelint/schemas/galaxy.json#L743