-
Notifications
You must be signed in to change notification settings - Fork 5
Change the scans to be pyansys scans #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #375 +/- ##
==========================================
- Coverage 81.17% 80.89% -0.28%
==========================================
Files 26 26
Lines 7504 7553 +49
Branches 1404 1420 +16
==========================================
+ Hits 6091 6110 +19
- Misses 973 1001 +28
- Partials 440 442 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merge branch 'maint/scans' of https://github.com/ansys/pydynamicreporting into maint/scans
.github/workflows/scan_sbom.yml
Outdated
- name: Generate SBOM with Syft | ||
uses: anchore/[email protected] | ||
with: | ||
format: spdx-json | ||
output-file: sbom.spdx.json | ||
upload-artifact: false | ||
|
||
- name: Upload SBOM as artifact | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: ${{ env.PACKAGE_NAME }}-sbom | ||
path: sbom.spdx.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easier to just set upload-artifact
to true and remove the upload step
@@ -41,7 +41,7 @@ dependencies = [ | |||
"django-guardian~=2.4", | |||
"tzlocal~=5.0", | |||
"numpy>=1.23.5,<3", | |||
"python-pptx==0.6.19", | |||
"python-pptx==0.6.23", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@margalva Any version beyond 0.6.19
will break powerpoint export. I have to do an upgrade in TFS before it can be upgraded here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@viseshrp thanks, I'm still working on this PR, but we do need to upgrade the version due to security issues on the current version - see https://data.safetycli.com/vulnerabilities/CVE-2023-4863/62149/
Let me know if this is more work than a simple update on both TFS and here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it requires some refactoring/rewrite of small portions of the code.
Change the scans to use pyansys and public actions instead of the ansys-internal scans