Skip to content

Change the scans to be pyansys scans #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from
Draft

Change the scans to be pyansys scans #375

wants to merge 37 commits into from

Conversation

margalva
Copy link
Collaborator

@margalva margalva commented Aug 6, 2025

Change the scans to use pyansys and public actions instead of the ansys-internal scans

@margalva margalva requested a review from viseshrp as a code owner August 6, 2025 19:47
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 37.77778% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.89%. Comparing base (59aac63) to head (593285c).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ynamicreporting/core/utils/report_remote_server.py 17.39% 35 Missing and 3 partials ⚠️
...ynamicreporting/core/utils/report_download_html.py 0.00% 8 Missing ⚠️
src/ansys/dynamicreporting/core/utils/encoders.py 0.00% 4 Missing ⚠️
...nsys/dynamicreporting/core/utils/report_objects.py 81.25% 3 Missing ⚠️
.../ansys/dynamicreporting/core/utils/report_utils.py 0.00% 2 Missing ⚠️
src/ansys/dynamicreporting/core/adr_service.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
- Coverage   81.17%   80.89%   -0.28%     
==========================================
  Files          26       26              
  Lines        7504     7553      +49     
  Branches     1404     1420      +16     
==========================================
+ Hits         6091     6110      +19     
- Misses        973     1001      +28     
- Partials      440      442       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines 38 to 49
- name: Generate SBOM with Syft
uses: anchore/[email protected]
with:
format: spdx-json
output-file: sbom.spdx.json
upload-artifact: false

- name: Upload SBOM as artifact
uses: actions/upload-artifact@v4
with:
name: ${{ env.PACKAGE_NAME }}-sbom
path: sbom.spdx.json

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easier to just set upload-artifact to true and remove the upload step

@@ -41,7 +41,7 @@ dependencies = [
"django-guardian~=2.4",
"tzlocal~=5.0",
"numpy>=1.23.5,<3",
"python-pptx==0.6.19",
"python-pptx==0.6.23",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@margalva Any version beyond 0.6.19 will break powerpoint export. I have to do an upgrade in TFS before it can be upgraded here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viseshrp thanks, I'm still working on this PR, but we do need to upgrade the version due to security issues on the current version - see https://data.safetycli.com/vulnerabilities/CVE-2023-4863/62149/
Let me know if this is more work than a simple update on both TFS and here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it requires some refactoring/rewrite of small portions of the code.

@margalva margalva marked this pull request as draft August 7, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants