Skip to content

docs: Added example on the battery cell simulation. #4361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 19, 2025

Conversation

MohammedAnsys
Copy link
Collaborator

Added End to End PyFluent example on Single Cell Battery Simulation based on Ansys Fluent documentation.

Please review the same!

Thanks!

@github-actions github-actions bot added documentation Documentation related (improving, adding, etc) examples Publishing PyFluent examples labels Aug 8, 2025
@hpohekar
Copy link
Collaborator

hpohekar commented Aug 8, 2025

Title should be as follows:

docs: Added example on the battery cell simulation.

This will avoid commit style failure.

@hpohekar hpohekar changed the title Added example on the battery cell simulation. docs: Added example on the battery cell simulation. Aug 8, 2025
@hpohekar
Copy link
Collaborator

hpohekar commented Aug 8, 2025

@MohammedAnsys

Please refer workflow file and add similar section on the following line:

https://github.com/ansys/pyfluent/blob/main/.github/workflows/execute-examples-weekly.yml#L153

- name: Execute single_battery_cell_workflow.py
   run: |
      python examples/00-fluent/single_battery_cell_workflow.py

This will help to run this example weekly in the GitHub.

@prmukherj
Copy link
Collaborator

Looks, good. You can try using ansys-fluent-visualization for rendering graphics as well from your side and provide your views on how it works: https://github.com/ansys/pyfluent-visualization

@MohammedAnsys
Copy link
Collaborator Author

Looks, good. You can try using ansys-fluent-visualization for rendering graphics as well from your side and provide your views on how it works: https://github.com/ansys/pyfluent-visualization

Hi @prmukherj, Thanks for reviewing the PR.
Surely will add visualization example on the repo.

@github-actions github-actions bot added maintenance General maintenance of the repo (libraries, cicd, etc) CI/CD labels Aug 8, 2025
@MohammedAnsys MohammedAnsys self-assigned this Aug 8, 2025
@hpohekar hpohekar self-requested a review August 8, 2025 11:13
Not relevant to this PR, since deleting it.
@github-actions github-actions bot removed the CI/CD label Aug 12, 2025
@github-actions github-actions bot added the CI/CD label Aug 13, 2025
@hpohekar
Copy link
Collaborator

@abhishekchitwar, what was the reason for deleting an utility file from pyfluent's core repo? 4853b00

cc. @seanpearsonuk, @MohammedAnsys

@abhishekchitwar
Copy link
Collaborator

abhishekchitwar commented Aug 13, 2025

@abhishekchitwar, what was the reason for deleting an utility file from pyfluent's core repo? 4853b00

cc. @seanpearsonuk, @MohammedAnsys

Hi @hpohekar, It seems this happened by mistake at first instance. I thought it's not related to @MohammedAnsys working branch. Since, that file is not related to the example contribution. Also, it shows few changes to that particular file while merging with main while pushing the PR.

@github-actions github-actions bot removed the CI/CD label Aug 13, 2025
@MohammedAnsys
Copy link
Collaborator Author

MohammedAnsys commented Aug 14, 2025

@seanpearsonuk , @hpohekar , @prmukherj , @abhishekchitwar
Thanks for reviewing and providing the feedback, with this contribution I have learned and get to speed with PyFluent module and Fluent as an application.
I also captured lesson learned and follow them with the future contributions.

Merging the PR with main.

Thanks

@MohammedAnsys MohammedAnsys enabled auto-merge (squash) August 14, 2025 09:27
@MohammedAnsys MohammedAnsys merged commit 2cf6e62 into main Aug 19, 2025
52 of 60 checks passed
@MohammedAnsys MohammedAnsys deleted the docs/example_on_battery_cell_simulation branch August 19, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related (improving, adding, etc) examples Publishing PyFluent examples maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants