Skip to content

fix: Some config and env var cleanup #4380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Some config and env var cleanup #4380

wants to merge 2 commits into from

Conversation

mkundu1
Copy link
Contributor

@mkundu1 mkundu1 commented Aug 12, 2025

  1. Remove the config equivalent to PYFLUENT_FLUENT_ROOT environment variable. That environment variable is only for development use.
  2. Remove the mentions of the environment PYFLUENT_LAUNCH_CONTAINER from user documentation. That environment variable is only for CI use.
  3. Fix a typo in slurm launcher.

@github-actions github-actions bot added documentation Documentation related (improving, adding, etc) bug Issue, problem or error in PyFluent labels Aug 12, 2025
prmukherj
prmukherj reviewed Aug 12, 2025
View reviewed changes
src/ansys/fluent/core/module_config.py
@@ -300,11 +300,6 @@ class Config:
lambda instance: instance._env.get("PYFLUENT_HIDE_LOG_SECRETS") == "1"
)

#: The Fluent root directory to be used for PyFluent, defaults to the value of ``PYFLUENT_FLUENT_ROOT`` environment variable.
fluent_root = _ConfigDescriptor["Config"](
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hpohekar
Copy link
Collaborator

Thanks a lot. Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hpohekar hpohekar hpohekar approved these changes

@prmukherj prmukherj prmukherj approved these changes

@seanpearsonuk seanpearsonuk Awaiting requested review from seanpearsonuk seanpearsonuk is a code owner

Assignees
No one assigned
Labels
bug Issue, problem or error in PyFluent documentation Documentation related (improving, adding, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkundu1 @hpohekar @prmukherj @pyansys-ci-bot