Skip to content

Conversation

valallansys
Copy link
Contributor

@valallansys valallansys commented Aug 7, 2025

Description

Add scalar_param method following dev to call PostProcessing

Issue linked

#4145

Checklist

@valallansys valallansys requested a review from a team as a code owner August 7, 2025 12:32
@valallansys valallansys requested review from germa89 and clatapie August 7, 2025 12:32
@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Aug 7, 2025
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

❌ Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.34%. Comparing base (de1cf18) to head (b8fe089).
⚠️ Report is 1 commits behind head on main.

❌ Your patch status has failed because the patch coverage (16.66%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4161      +/-   ##
==========================================
+ Coverage   91.31%   91.34%   +0.02%     
==========================================
  Files         193      193              
  Lines       15724    15730       +6     
==========================================
+ Hits        14358    14368      +10     
+ Misses       1366     1362       -4     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89
Copy link
Collaborator

germa89 commented Aug 7, 2025

@valallansys

We link PR/Issues with #, no !.

Soo.. it is #4145

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do move that method to mapdl_core.py as stated in my comment.

@germa89
Copy link
Collaborator

germa89 commented Aug 8, 2025

This PR is now on hold while we figure out the problem with the CLA bot.

Once @Revathyvenugopal162 or @jorgepiloto approves it, we can merge.

In the meantime, @valallansys you can work on this PR as normal. If you need to merge this fast, contact me.

@valallansys valallansys force-pushed the fix/add_scalar_param_to_inprocess branch from b1c0f27 to a6c4918 Compare August 8, 2025 09:40
@germa89 germa89 self-requested a review August 8, 2025 09:56
@ansys-cla-bot
Copy link

ansys-cla-bot bot commented Aug 8, 2025

⚠️ CLA Check Failed: Unable to identify commit authors

This pull request contains commits where the author information is missing or invalid. This typically happens when:

  • A user has changed their GitHub username
  • A user account has been deleted
  • Commit author data is corrupted

@germa89 germa89 merged commit fdb159a into main Aug 11, 2025
78 of 81 checks passed
@germa89 germa89 deleted the fix/add_scalar_param_to_inprocess branch August 11, 2025 10:25
@valallansys valallansys requested a review from koubaa August 11, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants