-
Notifications
You must be signed in to change notification settings - Fork 139
fix: Added scalar_param method to MapdlInProcess class #4161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (16.66%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #4161 +/- ##
==========================================
+ Coverage 91.31% 91.34% +0.02%
==========================================
Files 193 193
Lines 15724 15730 +6
==========================================
+ Hits 14358 14368 +10
+ Misses 1366 1362 -4 🚀 New features to boost your workflow:
|
We link PR/Issues with Soo.. it is #4145 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do move that method to mapdl_core.py
as stated in my comment.
This PR is now on hold while we figure out the problem with the CLA bot. Once @Revathyvenugopal162 or @jorgepiloto approves it, we can merge. In the meantime, @valallansys you can work on this PR as normal. If you need to merge this fast, contact me. |
b1c0f27
to
a6c4918
Compare
This pull request contains commits where the author information is missing or invalid. This typically happens when:
|
Description
Add scalar_param method following dev to call PostProcessing
Issue linked
#4145
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)