Skip to content

Conversation

indegro
Copy link
Contributor

@indegro indegro commented Nov 18, 2023

@@ -1,5 +1,23 @@

@movatechtoday
Copy link

Could someone take a look? The change is simple and will add completions for import statements

@movatechtoday
Copy link

Anyone?

@kjarrio
Copy link
Contributor

kjarrio commented Sep 12, 2025

Great work, I will test and review this PR during the weekend.

One question, does this take into account the "Location of imported grammars" configuration?

@kjarrio
Copy link
Contributor

kjarrio commented Sep 15, 2025

It works great! I'll be personally using your PR as part of my daily usage of the plugin from now on. However, it did not auto-complete imports from the configured lib folder like I mentioned it my comment above, so I added that feature myself. Can I make a pull request with that code on your branch in this PR which should update everything or is there better way to do that?
.

@parrt
Copy link
Member

parrt commented Sep 17, 2025

Sorry for the delay. I haven't looked at this project in so long I'm afraid to pull it in. sorry!

@kjarrio
Copy link
Contributor

kjarrio commented Sep 21, 2025

Hi Terence,
I fully understand and agree with your concerns, and for me personally, I'm already running my own version of the plugin and have been for a while, I pick and choose PRs and I also have some very specific customizations that won't serve the community at all, but I do have a really nice feature in the pipeline though :)

That being said, maybe having custom release channels such as Stable, EAP, UnStable, Nightly or whatever fits best, and get this plugin moving ahead a bit faster than it is. at this moment. I should probably move this discussion over to Issues, and see what the community thinks, and also gain a bit more insight into, if this is something that is actually needed or wanted.

I'd be willing to put in the work on figuring out how to get those channels configured and set up, automated, etc, if that ends up being a viable option.

Let me know your thoughts, and once again, thx for ANTLR!

@bjansen bjansen merged commit 7f42608 into antlr:master Sep 23, 2025
@bjansen
Copy link
Collaborator

bjansen commented Sep 23, 2025

Thanks for your contribution, @indegro!

@bjansen bjansen added this to the 1.25 milestone Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants