Skip to content

Conversation

aescastro
Copy link

@aescastro aescastro commented Dec 21, 2023

Hi there! I found this widget after wanting one in my Notion and it saved me a lot of time since otherwise I would have made this from scratch. I made a few changes for my own uses and figured I'd pass them along in return :).

This includes:

  • Updating it so that the widget background colour took up the entire viewport in dark mode. Here's a before and after:
    image
  • Changed the scrollbar of the widget to match Notion's scrollbar. Here's a before and after:
    image
  • Updating the colors in dark mode to match Notion's new dark mode colour (the colours had been changed since this was made). Shown in the above screenshots
  • Added a theme=system option which will make it so that if the query parameter theme=system then the widget's theme will match whatever the system setting is of the user. (ex. if user's computer/phone is in light mode then the widget will be the light version, if it's in dark mode then the widget is the dark version)
  • I also updated the colours of the refresh button to be black and white. Mostly something I did for me because I figured it would be more versatile this way as it wouldn't clash with other colours on the user's page. I can switch it back to the blue/purple if preferred though.
  • Changes to package.json, package-lock.json and yarn.lock which allowed me to run locally on my machine. I'm not sure why the vercel deployment is failing for this PR, I have a branch with deployed just fine for me on https://notion-embed-rss-git-generic-improvements-aescastros-projects.vercel.app/. I'd look into it more, but I am unable to look at the deployment logs from my account

Copy link

vercel bot commented Dec 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
notion-widget-rss ❌ Failed (Inspect) Dec 21, 2023 6:48am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant