fix NoCrossover missing offsprings #744
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxinabox
reviewed
Jul 18, 2025
| @@ -7,4 +9,4 @@ def __init__(self, *, n_parents=1, n_offsprings=1, prob=0.0, **kwargs): | |||
| super().__init__(n_parents, n_offsprings, prob, **kwargs) | |||
There was a problem hiding this comment.
Doing it this way means you always have exactly as many offsping as parents.
So either you can't take both as rguments (or you can but you need to error if they are not equal)
Or you need to do it differently:
e.g. start with list(itertools.chain.from_iterable(pop)) and if noffspring less than npartents randomly select a subset.
Or if it is higher randomly duplicate some
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #743
NoCrossoverdoes random selection which fails to propagate certain parents.This PR ensures that all parents are propagated as offsprings.
Thanks @oxinabox for the catch.