Merged
Conversation
utas-raymondng
requested changes
Feb 20, 2025
Collaborator
utas-raymondng
left a comment
utas-raymondng
left a comment
There was a problem hiding this comment.
I recall a need to add comment on why push the email to ogc api, not sure if I miss but didn't seems to see it here
| <artifactId>auth</artifactId> | ||
| <version>2.29.52</version> | ||
| </dependency> | ||
| <dependency> |
Collaborator
There was a problem hiding this comment.
can you put the depends version into the parent pom.xml dependency Management section? This applies to the all with version inside this pom.xml
Contributor
Author
Yes i put the comment in line 56 of Restapi (where invoking the |
utas-raymondng
requested changes
Feb 21, 2025
Collaborator
utas-raymondng
left a comment
utas-raymondng
left a comment
There was a problem hiding this comment.
One last comment
| <artifactId>spatial4j</artifactId> | ||
| <version>0.8</version> | ||
| </dependency> | ||
| <dependency> |
Collaborator
There was a problem hiding this comment.
Move duplicate version to a property above will save effort later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.