[AMORO-3994] Support Exposing AMS High Availability (HA) Status #3996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davedwwang
force-pushed
the
dev/ams-ha-state
branch
3 times, most recently
from
f530254 to
d5e820d
Compare
Contributor
Author
|
hi @zhoujinsong Would you mind reviewing this? I’d really appreciate it. Thanks! |
zhoujinsong
reviewed
Dec 30, 2025
Contributor
zhoujinsong
left a comment
zhoujinsong
left a comment
There was a problem hiding this comment.
@davedwwang Thanks a lot for your contribution! I left a comment, PTAL.
| private TServer optimizingServiceServer; | ||
| private Javalin httpServer; | ||
| private AmsServiceMetrics amsServiceMetrics; | ||
| private HAState haState = HAState.STANDBY; |
Contributor
There was a problem hiding this comment.
Maybe we can add a method haState in the HighAvailabilityContainer interface.
davedwwang
force-pushed
the
dev/ams-ha-state
branch
from
6458528 to
3a60624
Compare
davedwwang
force-pushed
the
dev/ams-ha-state
branch
from
3a60624 to
3ef1331
Compare
zhoujinsong
changed the title
zhoujinsong
approved these changes
Jan 5, 2026
Contributor
zhoujinsong
left a comment
zhoujinsong
left a comment
There was a problem hiding this comment.
LGTM.
Thanks for the conrtibution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
I hope to obtain the master-slave status of AMS through HTTP and metrics.
Close #3994.
Brief change log
Introducing a member variable to identify the master/slave status of the AMS. The HealthCheckController and AmsServiceMetrics use this field to retrieve the AMS's master/slave status.