CASSANDRA-18112 Support manual secondary index selection at the CQL level #4249
+3,396
−370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need some test cases for this pr? |
|
@Maxwell-Guo This is still in progress, but don't worry...there will be tests ;) |
maedhroz
force-pushed
the
CASSANDRA-18112
branch
3 times, most recently
from
e9d65b4 to
e201fc2
Compare
|
First real CI attempt: https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch-5/343/ |
belliottsmith
force-pushed
the
trunk
branch
2 times, most recently
from
df3eb40 to
54e39a9
Compare
adelapena
reviewed
Jul 25, 2025
test/distributed/org/apache/cassandra/distributed/test/sai/IndexHintsDistributedTest.java
Outdated
Show resolved
Hide resolved
src/java/org/apache/cassandra/cql3/restrictions/MergedRestriction.java
Outdated
Show resolved
Hide resolved
adelapena
reviewed
Jul 25, 2025
| @@ -292,11 +294,23 @@ public boolean needsFiltering(Index.Group indexGroup) | |||
| } | |||
|
|
|||
| @Override | |||
| public Index findSupportingIndex(Iterable<Index> indexes) | |||
| public Index findSupportingIndex(IndexRegistry indexRegistry, IndexHints indexHints) | |||
There was a problem hiding this comment.
I think we can deduplicate the two versions of findSupportingIndex and keep the changes done by CASSANDRA-19341 this way: adelapena@52fbc4b
adelapena
reviewed
Jul 25, 2025
adelapena
reviewed
Jul 28, 2025
patch by Caleb Rackliffe; reviewed by ? for CASSANDRA-18112 @co-authored-by ? @co-authored-by ?
maedhroz
force-pushed
the
CASSANDRA-18112
branch
from
e201fc2 to
4307fb5
Compare
maedhroz
commented
Aug 1, 2025
| @@ -109,7 +109,7 @@ public V1SSTableIndex(SSTableContext sstableContext, StorageAttachedIndex index) | |||
| catch (Throwable t) | |||
| { | |||
| FileUtils.closeQuietly(indexFiles); | |||
| FileUtils.closeQuietly(sstableContext); | |||
| FileUtils.closeQuietly(super.sstableContext); | |||
There was a problem hiding this comment.
I'll probably have to port this to 5.0 as well...but for now it's stabilizing tests for this patch...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch by Caleb Rackliffe; reviewed by ? for CASSANDRA-18112
This work is based on datastax#1670 by @adelapena
(We'll indicate co-authors on commit here)