-
Notifications
You must be signed in to change notification settings - Fork 3.8k
CASSANDRA-20938 CQLSSTableWriter supports ZSTD dictionary compression #4457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
yifan-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. I have some nits and questions.
src/java/org/apache/cassandra/io/sstable/AbstractSSTableSimpleWriter.java
Outdated
Show resolved
Hide resolved
src/java/org/apache/cassandra/io/sstable/AbstractSSTableSimpleWriter.java
Outdated
Show resolved
Hide resolved
| } | ||
| else | ||
| { | ||
| useOwner = owner; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious, the input owner is always null in the code base. Why do we ever need this parameter? Maybe @jacek-lewandowski can share some context. Looks like the parameter is added in the SSTable format API patch.
In case it is consumed by some external system, should it be more clear if the owner is assigned when creating the AbstractSSTableSimpleWriter? So that we can avoid the fallback logic here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added constructors accepting SSTable.Owner in both writers as suggested above. I would still keep this logic as is for integrations using this differently so it would be still compatible.
test/unit/org/apache/cassandra/io/sstable/CQLSSTableWriterTest.java
Outdated
Show resolved
Hide resolved
test/unit/org/apache/cassandra/io/sstable/CQLSSTableWriterTest.java
Outdated
Show resolved
Hide resolved
bb22bfe to
ccd2d49
Compare
patch by Stefan Miklosovic; reviewed by Yifan Cai for CASSANDRA-20938
ccd2d49 to
1a96b88
Compare
Thanks for sending a pull request! Here are some tips if you're new here:
Commit messages should follow the following format:
The Cassandra Jira