CASSANDRA-20941 Add nodetool command to import / export/ list compression dictionary #4458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smiklosovic
force-pushed
the
CASSANDRA-20941
branch
from
88974bb to
96d3193
Compare
smiklosovic
commented
Oct 31, 2025
yifan-c
requested changes
Nov 3, 2025
Contributor
yifan-c
left a comment
yifan-c
left a comment
There was a problem hiding this comment.
Could you please update the docs to include the new nodetool commands? I think NodetoolHelpCommandsOutputTest would also need to be updated.
src/java/org/apache/cassandra/db/compression/CompressionDictionary.java
Outdated
Show resolved
Hide resolved
src/java/org/apache/cassandra/db/compression/CompressionDictionary.java
Outdated
Show resolved
Hide resolved
src/java/org/apache/cassandra/db/compression/CompressionDictionaryDetailsTabularData.java
Outdated
Show resolved
Hide resolved
src/java/org/apache/cassandra/db/compression/CompressionDictionary.java
Outdated
Show resolved
Hide resolved
src/java/org/apache/cassandra/db/compression/CompressionDictionary.java
Outdated
Show resolved
Hide resolved
src/java/org/apache/cassandra/tools/nodetool/CompressionDictionary.java
Outdated
Show resolved
Hide resolved
src/java/org/apache/cassandra/db/compression/CompressionDictionaryDetailsTabularData.java
Outdated
Show resolved
Hide resolved
src/java/org/apache/cassandra/db/compression/CompressionDictionaryDetailsTabularData.java
Show resolved
Hide resolved
src/java/org/apache/cassandra/db/compression/CompressionDictionaryManagerMBean.java
Outdated
Show resolved
Hide resolved
src/java/org/apache/cassandra/db/compression/CompressionDictionaryManager.java
Outdated
Show resolved
Hide resolved
yifan-c
requested changes
Nov 3, 2025
src/java/org/apache/cassandra/db/compression/CompressionDictionaryDetailsTabularData.java
Show resolved
Hide resolved
src/java/org/apache/cassandra/db/compression/CompressionDictionaryDetailsTabularData.java
Outdated
Show resolved
Hide resolved
src/java/org/apache/cassandra/tools/nodetool/CompressionDictionary.java
Outdated
Show resolved
Hide resolved
smiklosovic
commented
Nov 4, 2025
src/java/org/apache/cassandra/tools/nodetool/CompressionDictionary.java
Outdated
Show resolved
Hide resolved
smiklosovic
commented
Nov 4, 2025
src/java/org/apache/cassandra/tools/nodetool/CompressionDictionary.java
Outdated
Show resolved
Hide resolved
smiklosovic
commented
Nov 4, 2025
src/java/org/apache/cassandra/tools/nodetool/CompressionDictionary.java
Outdated
Show resolved
Hide resolved
yifan-c
reviewed
Nov 5, 2025
src/java/org/apache/cassandra/schema/SystemDistributedKeyspace.java
Outdated
Show resolved
Hide resolved
yifan-c
reviewed
Nov 5, 2025
src/java/org/apache/cassandra/tools/nodetool/CompressionDictionaryCommandGroup.java
Outdated
Show resolved
Hide resolved
yifan-c
reviewed
Nov 5, 2025
smiklosovic
force-pushed
the
CASSANDRA-20941
branch
4 times, most recently
from
d73b713 to
c20de84
Compare
smiklosovic
force-pushed
the
CASSANDRA-20941
branch
from
c20de84 to
29efb21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests not added yet, too lazy to add them on this stage when prod code / approach is not reviewed yet and might change significantly